DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Angus Ainslie <angus@akkea.ca>
Cc: Lucas Stach <l.stach@pengutronix.de>,
	angus.ainslie@puri.sm, dmaengine@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Daniel Baluta <daniel.baluta@gmail.com>
Subject: [v3,4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices
Date: Wed, 23 Jan 2019 21:25:17 +0530	[thread overview]
Message-ID: <20190123155517.GR4635@vkoul-mobl> (raw)

On 23-01-19, 08:42, Angus Ainslie wrote:
> On 2019-01-23 08:31, Lucas Stach wrote:
> > Hi Angus,
> > 
> > Am Mittwoch, den 23.01.2019, 08:23 -0700 schrieb Angus Ainslie (Purism):
> > > On i.mx8mq, there are two sdma instances, and the common dma framework
> > > will get a channel dynamically from any available sdma instance
> > > whether
> > > it's the first sdma device or the second sdma device. Some IPs like
> > > SAI only work with sdma2 not sdma1. To make sure the sdma channel is
> > > from
> > > the correct sdma device, use an index to match.
> > > 
> > > Based on MLK-16104-2 by Robin Gong <yibin.gong@nxp.com>
> > 
> > This relies on the probe order of the devices (which should be treated
> > as random) for the match to find the right device. This is not
> > acceptable upstream.
> > 
> > The DT "dmas" property already specifies the correct SDMA device to use
> >  for a consumer, so the filter function should really match the OF node
> > of the SDMA device with the node specified in the dmas phandle in order
> > to pick the right SDMA engine.
> > 
> 
> Thanks Lucas, I'll fix it for rev 4

And fix the subsystem name, it is 'dmaengine: ...' not 'dma: ...'. git
log of the subsystem should give you good clue of the tags to be used..

Thanks

             reply	other threads:[~2019-01-23 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 15:55 Vinod Koul [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-23 15:42 [v3,4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices Angus Ainslie
2019-01-23 15:31 Lucas Stach
2019-01-23 15:23 Angus Ainslie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123155517.GR4635@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=angus.ainslie@puri.sm \
    --cc=angus@akkea.ca \
    --cc=daniel.baluta@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox