From: Vinod Koul <vkoul@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: dmaengine@vger.kernel.org
Subject: [1/2] dma: axi-dmac: don't check the number of frames for alignment
Date: Mon, 25 Feb 2019 12:22:17 +0530 [thread overview]
Message-ID: <20190225065217.GF31146@vkoul-mobl> (raw)
On 15-02-19, 11:17, Alexandru Ardelean wrote:
> Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog Devices
> AXI-DMAC DMA controller")
Do you mean to add a Fixes tag?
> For 2D transfers, there is no requirement for Y_LENGTH to be aligned
> to the bus-width (or anything). X_LENGTH is required to be aligned
> though.
>
> So, we shouldn't check that the number of frames is aligned.
Does this fix a bug as indicated by Fixes tag?
Lastly, it is dmaengine: xxx not dma: xxx Please fix that.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> drivers/dma/dma-axi-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index ffc0adc2f6ce..2c999113b989 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -485,7 +485,7 @@ static struct dma_async_tx_descriptor *axi_dmac_prep_interleaved(
>
> if (chan->hw_2d) {
> if (!axi_dmac_check_len(chan, xt->sgl[0].size) ||
> - !axi_dmac_check_len(chan, xt->numf))
> + xt->numf == 0)
> return NULL;
> if (xt->sgl[0].size + dst_icg > chan->max_length ||
> xt->sgl[0].size + src_icg > chan->max_length)
> --
> 2.17.1
next reply other threads:[~2019-02-25 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 6:52 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-26 8:36 [1/2] dma: axi-dmac: don't check the number of frames for alignment Ardelean, Alexandru
2019-02-26 8:01 Vinod Koul
2019-02-26 7:14 Ardelean, Alexandru
2019-02-15 9:17 Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225065217.GF31146@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox