From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] mfd: intel-lpss: Set the device in reset state when init From: Andy Shevchenko Message-Id: <20190409153625.GV9224@smile.fi.intel.com> Date: Tue, 9 Apr 2019 18:36:25 +0300 To: Binbin Wu Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDgsIDIwMTkgYXQgMDQ6MDk6MTBQTSArMDgwMCwgQmluYmluIFd1IHdyb3Rl Ogo+IEluIHZpcnR1YWxpemVkIHNldHVwLCB3aGVuIHN5c3RlbSByZWJvb3RzIGR1ZSB0byB3YXJt Cj4gcmVzZXQgaW50ZXJydXB0IHN0b3JtIGlzIHNlZW4uCj4gCj4gQ2FsbCBUcmFjZToKPiA8SVJR Pgo+IGR1bXBfc3RhY2srMHg3MC8weGE1Cj4gX19yZXBvcnRfYmFkX2lycSsweDJlLzB4YzAKPiBu b3RlX2ludGVycnVwdCsweDI0OC8weDI5MAo+ID8gYWRkX2ludGVycnVwdF9yYW5kb21uZXNzKzB4 MzAvMHgyMjAKPiBoYW5kbGVfaXJxX2V2ZW50X3BlcmNwdSsweDU0LzB4ODAKPiBoYW5kbGVfaXJx X2V2ZW50KzB4MzkvMHg2MAo+IGhhbmRsZV9mYXN0ZW9pX2lycSsweDkxLzB4MTUwCj4gaGFuZGxl X2lycSsweDEwOC8weDE4MAo+IGRvX0lSUSsweDUyLzB4ZjAKPiBjb21tb25faW50ZXJydXB0KzB4 Zi8weGYKPiA8L0lSUT4KPiBSSVA6IDAwMzM6MHg3NmZjMmNmYWJjMWQKPiBDb2RlOiAyNCAyOCBi ZiAwMyAwMCAwMCAwMCAzMSBjMCA0OCA4ZCAzNSA2MyA3NyAwZSAwMCA0OCA4ZCAxNSAyZQo+IDk0 IDBlIDAwIDRjIDg5IGY5IDQ5IDg5IGQ5IDRjIDg5IGQzIGU4IGI4IGUyIDAxIDAwIDQ4IDhiIDU0 IDI0IDE4Cj4gPDQ4PiA4OSBlZiA0OCA4OSBkZSA0YyA4OSBlMSBlOCBkNSA5NyAwMSAwMCA4NCBj MCA3NCAyZCA0OCA4YiAwNAo+IDI0Cj4gUlNQOiAwMDJiOjAwMDA3ZmZkMjQ3YzFmYzAgRUZMQUdT OiAwMDAwMDI5MyBPUklHX1JBWDogZmZmZmZmZmZmZmZmZmZkYQo+IFJBWDogMDAwMDAwMDAwMDAw MDAwMCBSQlg6IDAwMDA3ZmZkMjQ3YzFmZjAgUkNYOiAwMDAwMDAwMDAwMDNkM2NlCj4gUkRYOiAw MDAwMDAwMDAwMDAwMDAwIFJTSTogMDAwMDdmZmQyNDdjMWZmMCBSREk6IDAwMDA3NmZjMmNiYjYw MTAKPiBSQlA6IDAwMDA3NmZjMmNkZWQwMTAgUjA4OiAwMDAwN2ZmZDI0N2MyMjEwIFIwOTogMDAw MDdmZmQyNDdjMjJhMAo+IFIxMDogMDAwMDc2ZmMyOTQ2NTQ3MCBSMTE6IDAwMDAwMDAwMDAwMDAw MDAgUjEyOiAwMDAwN2ZmZDI0N2MxZmMwCj4gUjEzOiAwMDAwNzZmYzJjZThlNDcwIFIxNDogMDAw MDc2ZmMyN2VjOTk2MCBSMTU6IDAwMDAwMDAwMDAwMDA0MTQKPiBoYW5kbGVyczoKPiBbPDAwMDAw MDAwMGQzZmE5MTM+XSBpZG1hNjRfaXJxCj4gRGlzYWJsaW5nIElSUSAjMjcKPiAKPiBUbyBhdm9p ZCBpbnRlcnJ1cHQgc3Rvcm0sIHNldCB0aGUgZGV2aWNlIGluIHJlc2V0IHN0YXRlCj4gYmVmb3Jl IGJyaW5naW5nIG91dCB0aGUgZGV2aWNlIGZyb20gcmVzZXQgc3RhdGUuCgpSZXZpZXdlZC1ieTog QW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CgooSXQg c2hvdWxkbid0IHByZXZlbnQgdXNhZ2Ugb2Ygbm9fY29uc29sZV9zdXNwZW5kIGhhY2sgQUZBSUNT KQoKPiAKPiBDaGFuZ2Vsb2cgdjI6Cj4gLSBjb3JyZWN0IHRoZSBzdWJqZWN0IGxpbmUgYnkgYWRk aW5nICJtZmQ6ICIKPiAKPiBTaWduZWQtb2ZmLWJ5OiBCaW5iaW4gV3UgPGJpbmJpbi53dUBpbnRl bC5jb20+Cj4gQWNrZWQtYnk6IE1pa2EgV2VzdGVyYmVyZyA8bWlrYS53ZXN0ZXJiZXJnQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tZmQvaW50ZWwtbHBzcy5jIHwgMyArKysKPiAg MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L21mZC9pbnRlbC1scHNzLmMgYi9kcml2ZXJzL21mZC9pbnRlbC1scHNzLmMKPiBpbmRleCA1MGJm ZmMzLi5mZjNmYmExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL2ludGVsLWxwc3MuYwo+ICsr KyBiL2RyaXZlcnMvbWZkL2ludGVsLWxwc3MuYwo+IEBAIC0yNzMsNiArMjczLDkgQEAgc3RhdGlj IHZvaWQgaW50ZWxfbHBzc19pbml0X2Rldihjb25zdCBzdHJ1Y3QgaW50ZWxfbHBzcyAqbHBzcykK PiAgewo+ICAJdTMyIHZhbHVlID0gTFBTU19QUklWX1NTUF9SRUdfRElTX0RNQV9GSU47Cj4gIAo+ ICsJLyogU2V0IHRoZSBkZXZpY2UgaW4gcmVzZXQgc3RhdGUgKi8KPiArCXdyaXRlbCgwLCBscHNz LT5wcml2ICsgTFBTU19QUklWX1JFU0VUUyk7Cj4gKwo+ICAJaW50ZWxfbHBzc19kZWFzc2VydF9y ZXNldChscHNzKTsKPiAgCj4gIAlpbnRlbF9scHNzX3NldF9yZW1hcF9hZGRyKGxwc3MpOwo+IC0t IAo+IDIuNy40Cj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6AF3C10F0E for ; Tue, 9 Apr 2019 15:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B613520883 for ; Tue, 9 Apr 2019 15:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbfDIPga (ORCPT ); Tue, 9 Apr 2019 11:36:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:56368 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfDIPga (ORCPT ); Tue, 9 Apr 2019 11:36:30 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 08:36:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="159607994" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga002.fm.intel.com with ESMTP; 09 Apr 2019 08:36:26 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hDsnR-0004o0-Ly; Tue, 09 Apr 2019 18:36:25 +0300 Date: Tue, 9 Apr 2019 18:36:25 +0300 From: Andy Shevchenko To: Binbin Wu Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v2] mfd: intel-lpss: Set the device in reset state when init Message-ID: <20190409153625.GV9224@smile.fi.intel.com> References: <1554710950-21212-1-git-send-email-binbin.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1554710950-21212-1-git-send-email-binbin.wu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190409153625.dp6y6wcUFCIDB2nlak0havuDgl5NYHmr1VRcEPTGcqk@z> On Mon, Apr 08, 2019 at 04:09:10PM +0800, Binbin Wu wrote: > In virtualized setup, when system reboots due to warm > reset interrupt storm is seen. > > Call Trace: > > dump_stack+0x70/0xa5 > __report_bad_irq+0x2e/0xc0 > note_interrupt+0x248/0x290 > ? add_interrupt_randomness+0x30/0x220 > handle_irq_event_percpu+0x54/0x80 > handle_irq_event+0x39/0x60 > handle_fasteoi_irq+0x91/0x150 > handle_irq+0x108/0x180 > do_IRQ+0x52/0xf0 > common_interrupt+0xf/0xf > > RIP: 0033:0x76fc2cfabc1d > Code: 24 28 bf 03 00 00 00 31 c0 48 8d 35 63 77 0e 00 48 8d 15 2e > 94 0e 00 4c 89 f9 49 89 d9 4c 89 d3 e8 b8 e2 01 00 48 8b 54 24 18 > <48> 89 ef 48 89 de 4c 89 e1 e8 d5 97 01 00 84 c0 74 2d 48 8b 04 > 24 > RSP: 002b:00007ffd247c1fc0 EFLAGS: 00000293 ORIG_RAX: ffffffffffffffda > RAX: 0000000000000000 RBX: 00007ffd247c1ff0 RCX: 000000000003d3ce > RDX: 0000000000000000 RSI: 00007ffd247c1ff0 RDI: 000076fc2cbb6010 > RBP: 000076fc2cded010 R08: 00007ffd247c2210 R09: 00007ffd247c22a0 > R10: 000076fc29465470 R11: 0000000000000000 R12: 00007ffd247c1fc0 > R13: 000076fc2ce8e470 R14: 000076fc27ec9960 R15: 0000000000000414 > handlers: > [<000000000d3fa913>] idma64_irq > Disabling IRQ #27 > > To avoid interrupt storm, set the device in reset state > before bringing out the device from reset state. Reviewed-by: Andy Shevchenko (It shouldn't prevent usage of no_console_suspend hack AFAICS) > > Changelog v2: > - correct the subject line by adding "mfd: " > > Signed-off-by: Binbin Wu > Acked-by: Mika Westerberg > --- > drivers/mfd/intel-lpss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c > index 50bffc3..ff3fba1 100644 > --- a/drivers/mfd/intel-lpss.c > +++ b/drivers/mfd/intel-lpss.c > @@ -273,6 +273,9 @@ static void intel_lpss_init_dev(const struct intel_lpss *lpss) > { > u32 value = LPSS_PRIV_SSP_REG_DIS_DMA_FIN; > > + /* Set the device in reset state */ > + writel(0, lpss->priv + LPSS_PRIV_RESETS); > + > intel_lpss_deassert_reset(lpss); > > intel_lpss_set_remap_addr(lpss); > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko