From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] dmaengine: idma64: Move driver name to the header From: Christoph Hellwig Message-Id: <20190409163728.GA26872@infradead.org> Date: Tue, 9 Apr 2019 09:37:28 -0700 To: Andy Shevchenko Cc: Vinod Koul , dmaengine@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBBcHIgMDksIDIwMTkgYXQgMDY6MDI6MTlQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IFRoZXJlIGFyZSB0d28gZHJpdmVycyB0aGF0IGFyZSByZWx5aW5nIG9uIHRoZSBp RE1BIDY0LWJpdCBkcml2ZXIgbmFtZQo+IHRvIG1hdGNoLiBJbnN0ZWFkIG9mIGR1cGxpY2F0aW5n IHN0cmluZyBpbiBib3RoIG9mIHRoZW0sIGRlZGljYXRlCj4gYSBoZWFkZXIgZmlsZSBhbmQgc2hh cmUgaXQgYmV0d2VlbiB1c2Vycy4KCkhtbS4gIFdoeSBkbyB3ZSBoYXZlIHR3byBzZXBhcmF0ZSBk cml2ZXJzIGZvciB0aGUgc2FtZSBuYW1lPwoKU29tZXRoaW5nIGlzIHJhdGhlciBmaXNoeSB0aGVy ZS4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAE6C10F0E for ; Tue, 9 Apr 2019 16:37:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B1722084F for ; Tue, 9 Apr 2019 16:37:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NPbFIx25" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfDIQh3 (ORCPT ); Tue, 9 Apr 2019 12:37:29 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33958 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfDIQh3 (ORCPT ); Tue, 9 Apr 2019 12:37:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xGwGZu2v4kIB39gIuhG6d0yk9mI2M/lFF/ZPk/q2qLg=; b=NPbFIx25Eyq3G9g9/LlsnGT19 Ld5kGm4ap12LQ+gAPIdkgsVA9S1iKW9V4bkSHioH+U8VTAGvTuTBTYjeqZ3ixTyzx9GejIMjxsrTU kKIoY1YWBLqusEmo0AEDGnZiyz781Kgs/n5qxsqo/MD9Svr/XiSbsIK3rN6KdYHrl+P0lybNF4Gix PvnAI0oM3vB7THK0Ny4Pao12FIHATvIKUUzE0WfTDu/PlgQvAGUSp0oWxS+cD4sGEOjrfSJYcDHR3 DRASfv1IaVnJtRoGdy45ikY1OSWFPBDmrcUFbajAs092rYk303/I7NcYme8XTvYUA+WCGkPx4Yf6T frASrloAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtkW-0000hE-Ni; Tue, 09 Apr 2019 16:37:28 +0000 Date: Tue, 9 Apr 2019 09:37:28 -0700 From: Christoph Hellwig To: Andy Shevchenko Cc: Vinod Koul , dmaengine@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] dmaengine: idma64: Move driver name to the header Message-ID: <20190409163728.GA26872@infradead.org> References: <20190409150219.15094-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190409150219.15094-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190409163728.nEg3ImButdLw31ciLUs6zaivJPBlMPVtHP9ZAunDzis@z> On Tue, Apr 09, 2019 at 06:02:19PM +0300, Andy Shevchenko wrote: > There are two drivers that are relying on the iDMA 64-bit driver name > to match. Instead of duplicating string in both of them, dedicate > a header file and share it between users. Hmm. Why do we have two separate drivers for the same name? Something is rather fishy there.