From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: bcm2835: Drop duplicate capability setting. From: Vinod Koul Message-Id: <20190426112335.GR28103@vkoul-mobl> Date: Fri, 26 Apr 2019 16:53:35 +0530 To: Michal Suchanek Cc: bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Williams , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden List-ID: T24gMDQtMDQtMTksIDE5OjI1LCBNaWNoYWwgU3VjaGFuZWsgd3JvdGU6Cj4gU2lnbmVkLW9mZi1i eTogTWljaGFsIFN1Y2hhbmVrIDxtc3VjaGFuZWtAc3VzZS5kZT4KPiAtLS0KPiAgZHJpdmVycy9k bWEvYmNtMjgzNS1kbWEuYyB8IDEgLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9iY20yODM1LWRtYS5jIGIvZHJpdmVycy9kbWEv YmNtMjgzNS1kbWEuYwo+IGluZGV4IGVjOGEyOTFkNjJiYS4uZTM4YjE5ZGQyODk1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZG1hL2JjbTI4MzUtZG1hLmMKPiArKysgYi9kcml2ZXJzL2RtYS9iY20y ODM1LWRtYS5jCj4gQEAgLTg5MSw3ICs4OTEsNiBAQCBzdGF0aWMgaW50IGJjbTI4MzVfZG1hX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlkbWFfY2FwX3NldChETUFfU0xB VkUsIG9kLT5kZGV2LmNhcF9tYXNrKTsKPiAgCWRtYV9jYXBfc2V0KERNQV9QUklWQVRFLCBvZC0+ ZGRldi5jYXBfbWFzayk7Cj4gIAlkbWFfY2FwX3NldChETUFfQ1lDTElDLCBvZC0+ZGRldi5jYXBf bWFzayk7Cj4gLQlkbWFfY2FwX3NldChETUFfU0xBVkUsIG9kLT5kZGV2LmNhcF9tYXNrKTsKPiAg CWRtYV9jYXBfc2V0KERNQV9NRU1DUFksIG9kLT5kZGV2LmNhcF9tYXNrKTsKPiAgCW9kLT5kZGV2 LmRldmljZV9hbGxvY19jaGFuX3Jlc291cmNlcyA9IGJjbTI4MzVfZG1hX2FsbG9jX2NoYW5fcmVz b3VyY2VzOwo+ICAJb2QtPmRkZXYuZGV2aWNlX2ZyZWVfY2hhbl9yZXNvdXJjZXMgPSBiY20yODM1 X2RtYV9mcmVlX2NoYW5fcmVzb3VyY2VzOwoKQXBwbGllZCwgdGhhbmtzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E350C43219 for ; Fri, 26 Apr 2019 11:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2016B206BF for ; Fri, 26 Apr 2019 11:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556277822; bh=3bzZ2r5lWZdVtw8CtpxfUbi9NGF6ozDmxq0Do81o3BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j3Q8usqwlTONfDjaERI/BTMO74HtD19K37HO8LMj51jFI5Yrrhk6N7rcQNypj4d0D SpZyJbmVmrL+YqRC6+uUdJ5i8aWfY45Ukd1Gx0CYCGM1DjVCNA6ZjgCrh3tq3A43ES J/nFuX+qUTDHmWy8sSeAVaXidvMwuxMuEKWeNwbQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbfDZLXl (ORCPT ); Fri, 26 Apr 2019 07:23:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:59564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfDZLXl (ORCPT ); Fri, 26 Apr 2019 07:23:41 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4315C206A3; Fri, 26 Apr 2019 11:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556277821; bh=3bzZ2r5lWZdVtw8CtpxfUbi9NGF6ozDmxq0Do81o3BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=URPn1sEQTjeNJIYIJ51giByxL0CctrDMTbbQ/enjX7olLMfytVYS0Qx6HiJLhYoUd DhzuxalaCE5axg+cWf4D7Te+TvLmrFo9rW5pQmpOjY2OxqQXPMIwLivcYVW3160A5t fcam28ZA5OYbX7MPgNWhrgYAf1DcT/rKI/LOAuCk= Date: Fri, 26 Apr 2019 16:53:35 +0530 From: Vinod Koul To: Michal Suchanek Cc: bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Williams , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden Subject: Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting. Message-ID: <20190426112335.GR28103@vkoul-mobl> References: <20190404172503.12155-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190404172503.12155-1-msuchanek@suse.de> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190426112335.LTN-Ci_Gxbwex15RJHRFPJLkjoyCdWGDtohI3mpGFs0@z> On 04-04-19, 19:25, Michal Suchanek wrote: > Signed-off-by: Michal Suchanek > --- > drivers/dma/bcm2835-dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c > index ec8a291d62ba..e38b19dd2895 100644 > --- a/drivers/dma/bcm2835-dma.c > +++ b/drivers/dma/bcm2835-dma.c > @@ -891,7 +891,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev) > dma_cap_set(DMA_SLAVE, od->ddev.cap_mask); > dma_cap_set(DMA_PRIVATE, od->ddev.cap_mask); > dma_cap_set(DMA_CYCLIC, od->ddev.cap_mask); > - dma_cap_set(DMA_SLAVE, od->ddev.cap_mask); > dma_cap_set(DMA_MEMCPY, od->ddev.cap_mask); > od->ddev.device_alloc_chan_resources = bcm2835_dma_alloc_chan_resources; > od->ddev.device_free_chan_resources = bcm2835_dma_free_chan_resources; Applied, thanks -- ~Vinod