From: Simon Horman <horms@verge.net.au>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"HIROYUKI YOKOYAMA" <hiroyuki.yokoyama.vx@renesas.com>
Subject: Re: [PATCH] dmaengine: rcar-dmac: Update copyright information
Date: Thu, 9 May 2019 14:55:29 +0200 [thread overview]
Message-ID: <20190509125528.d7eryp5iv45yn2mp@verge.net.au> (raw)
In-Reply-To: <20190426115343.GY28103@vkoul-mobl>
On Fri, Apr 26, 2019 at 05:23:43PM +0530, Vinod Koul wrote:
> On 25-04-19, 03:52, Yoshihiro Shimoda wrote:
> > Hi Geert-san,
> >
> > > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM
> > >
> > > Hi Niklas, Shimoda-san,
> > >
> > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund
> > > <niklas.soderlund@ragnatech.se> wrote:
> > > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote:
> > > > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote:
> > > > > Not strictly related, but is it appropriate to:
> > > > >
> > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/
> > >
> > > That may make sense...
> > >
> > > > > 2. Remove drivers/dma/sh/sudmac.c which appears unused
> > > >
> > > > I let someone with a better grasp of history answer this one. From my
> > > > side removing drivers which are unused seems like a good idea :-)
> > >
> > > There seem to be some (half-baked?) interaction between sudmac.c and
> > > drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c.
> > > These don't seem to be used at all on Renesas ARM platforms, but
> > > CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and
> > > multi_v7_defconfig?
> > >
> > > Shimoda-san: can you please enlighten us?
> > > Thanks!
> >
> > Sure.
> >
> > - SH4A / sh7757 has SUDMAC. (any other Renesas ARM platforms don't have it).
> > # sh7757 is not public product though...
> > - At first, I added this SUDMAC support into r8a66597-udc.
> > - But, our direction is changed by some reason. So, we use renesas_usbhs driver anyway.
> > - The renesas_usbhs supports dmaengine, so I added dma/sh/sudmac driver.
> > - However, for some reasons (maybe I'm busy for other projects?),
> > I didn't add using the sudmac support into arch/sh/kernel/cpu/sh4a/setup-sh7757.c.
> > - So, no one uses both r8a66597-udc and sudmac now.
> >
> > From 2013 (added the sudmac driver) to now, since no one integrated the sudmac for sh7757,
> > I think we can remove the driver.
>
> And where is the removal patch :)
Sorry for the delay, I have just posted
[PATCH] dmaengine: sudmac: remove unused driver
Shimoda-san, can we go further and also:
1. Remove the r8a66597-udc driver, which also seems unused
2. Remove (minimal) sudmac integration from usbhs ?
next prev parent reply other threads:[~2019-05-09 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 18:26 dmaengine: rcar-dmac: Update copyright information Niklas Söderlund
2019-04-10 18:26 ` [PATCH] " Niklas Söderlund
2019-04-11 8:49 ` Simon Horman
2019-04-11 8:49 ` [PATCH] " Simon Horman
2019-04-11 15:17 ` Niklas Söderlund
2019-04-11 15:17 ` [PATCH] " Niklas Söderlund
2019-04-24 12:22 ` Geert Uytterhoeven
2019-04-24 12:22 ` [PATCH] " Geert Uytterhoeven
2019-04-25 3:52 ` Yoshihiro Shimoda
2019-04-25 3:52 ` [PATCH] " Yoshihiro Shimoda
2019-04-26 11:53 ` Vinod Koul
2019-04-26 11:53 ` [PATCH] " Vinod Koul
2019-05-09 12:55 ` Simon Horman [this message]
2019-05-10 11:03 ` Yoshihiro Shimoda
2019-05-13 12:20 ` Simon Horman
2019-04-26 11:54 ` Vinod Koul
2019-04-26 11:54 ` [PATCH] " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509125528.d7eryp5iv45yn2mp@verge.net.au \
--to=horms@verge.net.au \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hiroyuki.yokoyama.vx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox