From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0392C31E47 for ; Wed, 12 Jun 2019 12:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88132208CA for ; Wed, 12 Jun 2019 12:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560342384; bh=hapQOj2oV7lQmVlqOLUMvP5SDFlMe6BD5fHLQJfjJL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=M/YJGgC55ZgZs5xPZWN6gVeNrZsDbv7Riur6xDIYsEwulgLRQPy1mM9mDiZH1AuA5 2zagL6PV9Whuyor76vP1BSWG6xl0RTeboiaTyCrNgNmaW/FzPspM9wmNi3Ivo2PoWx W+4gwyz8Kd/jgemz2ROITm1dwn43XdvHpaqPXUxI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732345AbfFLM0T (ORCPT ); Wed, 12 Jun 2019 08:26:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfFLM0T (ORCPT ); Wed, 12 Jun 2019 08:26:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26965208CA; Wed, 12 Jun 2019 12:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560342378; bh=hapQOj2oV7lQmVlqOLUMvP5SDFlMe6BD5fHLQJfjJL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlVHyjhoutddiPVuU37MsTDl/etrcfE/rThCBroetqyu1eMVEqDUPYPgO9FSKfrVW q6UqidoZDJ1rYvU7vlG/fRU1SI5LqfKhFuD75u5e/N0JiFEpiHGqTtEBPNwJ3Q0xrd 67lmJduvIq5J4y5xJV+vZVmh9v6vBTEuKoLVDBpc= From: Greg Kroah-Hartman To: dan.j.williams@intel.com, vkoul@kernel.org Cc: Greg Kroah-Hartman , Sudeep Dutt , Ashutosh Dixit , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] dma: mic_x100_dma: no need to check return value of debugfs_create functions Date: Wed, 12 Jun 2019 14:25:56 +0200 Message-Id: <20190612122557.24158-5-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190612122557.24158-1-gregkh@linuxfoundation.org> References: <20190612122557.24158-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Sudeep Dutt Cc: Ashutosh Dixit Cc: Dan Williams Cc: Vinod Koul Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/dma/mic_x100_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c index 6a91e28d537d..584e09661507 100644 --- a/drivers/dma/mic_x100_dma.c +++ b/drivers/dma/mic_x100_dma.c @@ -728,10 +728,8 @@ static int mic_dma_driver_probe(struct mbus_device *mbdev) if (mic_dma_dbg) { mic_dma_dev->dbg_dir = debugfs_create_dir(dev_name(&mbdev->dev), mic_dma_dbg); - if (mic_dma_dev->dbg_dir) - debugfs_create_file("mic_dma_reg", 0444, - mic_dma_dev->dbg_dir, mic_dma_dev, - &mic_dma_reg_fops); + debugfs_create_file("mic_dma_reg", 0444, mic_dma_dev->dbg_dir, + mic_dma_dev, &mic_dma_reg_fops); } return 0; } -- 2.22.0