Re: [PATCH 6/6] dma: qcom: hidma: no need to check return value of debugfs_create functions

Greg Kroah-Hartman
2019-06-12T16:47:13Z

On Wed, Jun 12, 2019 at 12:17:31PM -0400, Sinan Kaya wrote:
> On 6/12/2019 11:39 AM, Greg Kroah-Hartman wrote:
> >> Interesting. Wouldn't debugfs_create_file() blow up if dir is NULL
> >> for some reason?
> > It will create a file in the root of debugfs. But how will that happen?
> > debugfs_create_dir() can not return NULL.
>
> I see.
>
> >
> >> + debugfs_create_file("stats", S_IRUGO, dir, chan,
> >> + &hidma_chan_fops);
> >>
> >> Note that code ignores the return value of hidma_debug_init();
> >> It was just trying to do clean up on debugfs failure by calling
> >>
> >> debugfs_remove_recursive(dmadev->debugfs);
> > Is that a problem?
>
> I just wanted to double check. You probably want to remove the return
> value on debugfs_create_file() to prevent others from doing the same
> thing.

That is my long-term goal, I have a ways to go still :)

> Acked-by: Sinan Kaya <okaya@kernel.org>

Great, thanks for the review.

greg k-h