From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8662DC48BE3 for ; Fri, 21 Jun 2019 12:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A5A02084E for ; Fri, 21 Jun 2019 12:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfFUMxW (ORCPT ); Fri, 21 Jun 2019 08:53:22 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:34613 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbfFUMxW (ORCPT ); Fri, 21 Jun 2019 08:53:22 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1heJ2R-0002To-Qd; Fri, 21 Jun 2019 14:53:07 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1heJ2P-0004TF-LK; Fri, 21 Jun 2019 14:53:05 +0200 Date: Fri, 21 Jun 2019 14:53:05 +0200 From: Michael Olbrich To: yibin.gong@nxp.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dan.j.williams@intel.com, thesven73@gmail.com, linux-imx@nxp.com, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2] dmaengine: imx-sdma: remove BD_INTR for channel0 Message-ID: <20190621125305.jpmkrwfgruxs2yzt@pengutronix.de> Mail-Followup-To: yibin.gong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dan.j.williams@intel.com, thesven73@gmail.com, linux-imx@nxp.com, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, kernel@pengutronix.de References: <20190621082306.34415-1-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621082306.34415-1-yibin.gong@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:49:15 up 34 days, 19:07, 89 users, load average: 0.03, 0.10, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mol@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, Jun 21, 2019 at 04:23:06PM +0800, yibin.gong@nxp.com wrote: > From: Robin Gong > > It is possible for an irq triggered by channel0 to be received later > after clks are disabled once firmware loaded during sdma probe. If > that happens then clearing them by writing to SDMA_H_INTR won't work > and the kernel will hang processing infinite interrupts. Actually, > don't need interrupt triggered on channel0 since it's pollling > SDMA_H_STATSTOP to know channel0 done rather than interrupt in > current code, just clear BD_INTR to disable channel0 interrupt to > avoid the above case. > This issue was brought by commit 1d069bfa3c78 ("dmaengine: imx-sdma: > ack channel 0 IRQ in the interrupt handler") which didn't take care > the above case. > > Fixes: 1d069bfa3c78 ("dmaengine: imx-sdma: ack channel 0 IRQ in the interrupt handler") > Cc: stable@vger.kernel.org #5.0+ > Signed-off-by: Robin Gong > Reported-by: Sven Van Asbroeck > Tested-by: Sven Van Asbroeck Reviewed-by: Michael Olbrich > --- > drivers/dma/imx-sdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index deea9aa..b5a1ee2 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -742,7 +742,7 @@ static int sdma_load_script(struct sdma_engine *sdma, void *buf, int size, > spin_lock_irqsave(&sdma->channel_0_lock, flags); > > bd0->mode.command = C0_SETPM; > - bd0->mode.status = BD_DONE | BD_INTR | BD_WRAP | BD_EXTD; > + bd0->mode.status = BD_DONE | BD_WRAP | BD_EXTD; > bd0->mode.count = size / 2; > bd0->buffer_addr = buf_phys; > bd0->ext_buffer_addr = address; > @@ -1064,7 +1064,7 @@ static int sdma_load_context(struct sdma_channel *sdmac) > context->gReg[7] = sdmac->watermark_level; > > bd0->mode.command = C0_SETDM; > - bd0->mode.status = BD_DONE | BD_INTR | BD_WRAP | BD_EXTD; > + bd0->mode.status = BD_DONE | BD_WRAP | BD_EXTD; > bd0->mode.count = sizeof(*context) / 4; > bd0->buffer_addr = sdma->context_phys; > bd0->ext_buffer_addr = 2048 + (sizeof(*context) / 4) * channel; > -- > 2.7.4 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |