From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D58FEC46499 for ; Fri, 5 Jul 2019 12:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC2D4218C9 for ; Fri, 5 Jul 2019 12:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562331007; bh=SkovIuVVyMzxFaOZoi3i2O3ZZrHSAu1M22ejXxbkKQw=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=Dk+sVkcC9n7zw6fScSgdxwo0QiqPXEPzORNuWFMKtaKq93/LIkEsB3t1cGZtaOLxE ykXojsH2NVmm9MrmSO5eAgbEZR36EPswLWiyBcpaS069V9kNEjfQHF365UeU+qiyP3 OwCnumsm5fW0neKYstko/dLINWmEGEVQ7nG/wQ0g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbfGEMuH (ORCPT ); Fri, 5 Jul 2019 08:50:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:37152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727991AbfGEMuH (ORCPT ); Fri, 5 Jul 2019 08:50:07 -0400 Received: from localhost (unknown [122.167.76.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C2E62184C; Fri, 5 Jul 2019 12:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562331006; bh=SkovIuVVyMzxFaOZoi3i2O3ZZrHSAu1M22ejXxbkKQw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bCrhMQNjtA9DVZoUzobukEaip6FmeXbLASfbZAuxtV8yRQgYaUCv6wTUQMIYNZgGU tfrpEoPDeuagdnvy4wjXW5nsfjkaVrp72kkqyPXvjJjXphh2ei+eBpCPsofGJGhILQ XOdUk4T3JIfbFC4y2LBBSZGE4lVYSsAhDg8Obk5w= Date: Fri, 5 Jul 2019 18:16:46 +0530 From: Vinod Koul To: Sven Van Asbroeck Cc: Robin Gong , Dan Williams , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path Message-ID: <20190705124646.GD2911@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624140731.24080-1-TheSven73@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 24-06-19, 10:07, Sven Van Asbroeck wrote: Quoting orignal patch for better context: > + if (pdata) { > + ret = sdma_get_firmware(sdma, pdata->fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware from platform data\n"); > + } else { > + /* > + * Because that device tree does not encode ROM script address, > + * the RAM script in firmware is mandatory for device tree > + * probe, otherwise it fails. > + */ > + ret = of_property_read_string(np, "fsl,sdma-ram-script-name", > + &fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > + else { > + ret = sdma_get_firmware(sdma, fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } > + } > + On 05-07-19, 08:26, Sven Van Asbroeck wrote: > Hi Vinod, > > On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote: > > > > > + if (ret) > > > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > > > > if should have braces! > > Applied after fixing braces! > > checkpatch.pl output after adding braces: > > WARNING: braces {} are not necessary for single statement blocks > #102: FILE: drivers/dma/imx-sdma.c:2165: > + if (ret) { > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } there is an else here too! With the patch the checkpatch warns: CHECK: braces {} should be used on all arms of this statement #201: FILE: drivers/dma/imx-sdma.c:2161: + if (ret) [...] + else { [...] Even if the if is a single block and else being multi block, if would need matching brances. With the change pushed: total: 0 errors, 0 warnings, 0 checks, 60 lines checked -- ~Vinod