From: Sascha Hauer <s.hauer@pengutronix.de>
To: dmaengine@vger.kernel.org
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Green Wan" <green.wan@sifive.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Sean Wang" <sean.wang@mediatek.com>,
"Eugeniy Paltsev" <Eugeniy.Paltsev@synopsys.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: [PATCH v3 0/9] dmaengine: virt-dma related fixes
Date: Mon, 16 Dec 2019 11:53:19 +0100 [thread overview]
Message-ID: <20191216105328.15198-1-s.hauer@pengutronix.de> (raw)
Several drivers call vchan_dma_desc_free_list() or vchan_vdesc_fini() under
&vc->lock. This is not allowed and the first two patches fix this up. If you
are a DMA driver maintainer, the first two patches are the reason you are on
Cc.
The remaining patches are the original purpose of this series:
The i.MX SDMA driver leaks memory when a currently running descriptor is
aborted. Calling vchan_terminate_vdesc() on it to fix this revealed that
the virt-dma support calls the desc_free with the spin_lock held. This
doesn't work for the SDMA driver because it calls dma_free_coherent in
its desc_free hook. This series aims to fix that up.
Changes since v2:
- change drivers to not call vchan_dma_desc_free_list() under spin_lock
- remove debug message from vchan_dma_desc_free_list()
Changes since v1:
- rebase on v5.5-rc1
- Swap patches 1 and 2 for bisectablity
- Rename desc_aborted to desc_terminated
- Free up terminated descriptors immediately instead of letting them accumulate
Sascha Hauer (9):
dmaengine: bcm2835: do not call vchan_vdesc_fini() with lock held
dmaengine: virt-dma: Add missing locking
dmaengine: virt-dma: remove debug message
dmaengine: virt-dma: Do not call desc_free() under a spin_lock
dmaengine: virt-dma: Add missing locking around list operations
dmaengine: virt-dma: use vchan_vdesc_fini() to free descriptors
dmaengine: imx-sdma: rename function
dmaengine: imx-sdma: find desc first in sdma_tx_status
dmaengine: imx-sdma: Fix memory leak
drivers/dma/bcm2835-dma.c | 5 +--
.../dma/dw-axi-dmac/dw-axi-dmac-platform.c | 8 +---
drivers/dma/imx-sdma.c | 37 +++++++++++--------
drivers/dma/mediatek/mtk-uart-apdma.c | 3 +-
drivers/dma/owl-dma.c | 3 +-
drivers/dma/s3c24xx-dma.c | 22 +++++------
drivers/dma/sf-pdma/sf-pdma.c | 4 +-
drivers/dma/sun4i-dma.c | 3 +-
drivers/dma/virt-dma.c | 10 ++---
drivers/dma/virt-dma.h | 27 ++++++++------
10 files changed, 63 insertions(+), 59 deletions(-)
--
2.24.0
next reply other threads:[~2019-12-16 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 10:53 Sascha Hauer [this message]
2019-12-16 10:53 ` [PATCH 1/9] dmaengine: bcm2835: do not call vchan_vdesc_fini() with lock held Sascha Hauer
2019-12-16 10:53 ` [PATCH 2/9] dmaengine: virt-dma: Add missing locking Sascha Hauer
2019-12-16 10:53 ` [PATCH 3/9] dmaengine: virt-dma: remove debug message Sascha Hauer
2019-12-16 10:53 ` [PATCH 4/9] dmaengine: virt-dma: Do not call desc_free() under a spin_lock Sascha Hauer
2019-12-16 10:53 ` [PATCH 5/9] dmaengine: virt-dma: Add missing locking around list operations Sascha Hauer
2019-12-16 10:53 ` [PATCH 6/9] dmaengine: virt-dma: use vchan_vdesc_fini() to free descriptors Sascha Hauer
2019-12-16 10:53 ` [PATCH 7/9] dmaengine: imx-sdma: rename function Sascha Hauer
2019-12-16 10:53 ` [PATCH 8/9] dmaengine: imx-sdma: find desc first in sdma_tx_status Sascha Hauer
2019-12-16 10:53 ` [PATCH 9/9] dmaengine: imx-sdma: Fix memory leak Sascha Hauer
2019-12-18 10:09 ` Robin Gong
2019-12-16 11:49 ` [PATCH v3 0/9] dmaengine: virt-dma related fixes Peter Ujfalusi
2019-12-24 6:25 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216105328.15198-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=afaerber@suse.de \
--cc=dmaengine@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=green.wan@sifive.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-imx@nxp.com \
--cc=mripard@kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robert.jarzmik@free.fr \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox