Re: [PATCH v7 04/12] dmaengine: Add metadata_ops for dma_async_tx_descriptor

Peter Ujfalusi
2019-12-20T08:48:02Z

Hi Vinod,

On 20/12/2019 10.32, Vinod Koul wrote:
> Hi Peter,
>
> On 09-12-19, 11:43, Peter Ujfalusi wrote:
>
>> +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc,
>> + void *data, size_t len)
>> +{
>> + int ret;
>> +
>> + if (!desc)
>> + return -EINVAL;
>> +
>> + ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT);
>> + if (ret)
>> + return ret;
>> +
>> + if (!desc->metadata_ops || !desc->metadata_ops->attach)
>> + return -ENOTSUPP;
>> +
>> + return desc->metadata_ops->attach(desc, data, len);
>
> this looks good to me, only thing is we should check if people are
> mixing the modes :)

desc_check_and_set_metadata_mode() does the checking to make sure that
the modes are not mixed.

- Péter