From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26513C2D0CF for ; Tue, 24 Dec 2019 06:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D693320730 for ; Tue, 24 Dec 2019 06:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577168754; bh=InoE8ryzjR+FID2QK7KPw32193qUgMsnYRn9+U++QDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EX+lEUdduDgK3O8S+4FFcEU3U88YUT6fsv2QWsk5TNpClHZKekmL8vCmE224WkdIK /y1R9YJF1y0wZ6RSTcQhANXzOgXIXkwxWiB30HecWuobsEH7I+rzUL0zNAVEwU19gu kisdrE++f9QLkxoituK09VM1rRsufK01CYS5vNtk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726020AbfLXGZy (ORCPT ); Tue, 24 Dec 2019 01:25:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:54456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbfLXGZy (ORCPT ); Tue, 24 Dec 2019 01:25:54 -0500 Received: from localhost (unknown [122.167.68.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D89F4206CB; Tue, 24 Dec 2019 06:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577168753; bh=InoE8ryzjR+FID2QK7KPw32193qUgMsnYRn9+U++QDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SK2AZDRtPCzRvSUy+gpty5CrqB1jckZ6y+Itx/Um154hA9qntpCsm/3UdO0zc1xGW uFMkO5LygHb3YW5QTabCdz3ZQnE6Lutf0k2K89ZBFtVWo9JsrwUr677S84Y/OtSd8Z OEHOoxhmV4YoQlnUJTpR5CGKQl2hTyKnPVBRPSIw= Date: Tue, 24 Dec 2019 11:55:47 +0530 From: Vinod Koul To: Sascha Hauer Cc: dmaengine@vger.kernel.org, Peter Ujfalusi , Florian Fainelli , Maxime Ripard , Green Wan , Kukjin Kim , Krzysztof Kozlowski , Andreas =?iso-8859-1?Q?F=E4rber?= , Sean Wang , Eugeniy Paltsev , Pengutronix Kernel Team , NXP Linux Team , Robert Jarzmik Subject: Re: [PATCH v3 0/9] dmaengine: virt-dma related fixes Message-ID: <20191224062547.GJ2536@vkoul-mobl> References: <20191216105328.15198-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191216105328.15198-1-s.hauer@pengutronix.de> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 16-12-19, 11:53, Sascha Hauer wrote: > Several drivers call vchan_dma_desc_free_list() or vchan_vdesc_fini() under > &vc->lock. This is not allowed and the first two patches fix this up. If you > are a DMA driver maintainer, the first two patches are the reason you are on > Cc. > > The remaining patches are the original purpose of this series: > The i.MX SDMA driver leaks memory when a currently running descriptor is > aborted. Calling vchan_terminate_vdesc() on it to fix this revealed that > the virt-dma support calls the desc_free with the spin_lock held. This > doesn't work for the SDMA driver because it calls dma_free_coherent in > its desc_free hook. This series aims to fix that up. Applied all, thanks -- ~Vinod