From: Dmitry Osipenko <digetx@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 02/12] dmaengine: tegra-apb: Implement synchronization callback
Date: Sun, 29 Dec 2019 17:55:15 +0300 [thread overview]
Message-ID: <20191229145525.533-3-digetx@gmail.com> (raw)
In-Reply-To: <20191229145525.533-1-digetx@gmail.com>
The ISR tasklet could be kept scheduled after DMA transfer termination,
let's add synchronization callback which blocks until tasklet is finished.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/dma/tegra20-apb-dma.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 319f31d27014..664e9c5df3ba 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -798,6 +798,13 @@ static int tegra_dma_terminate_all(struct dma_chan *dc)
return 0;
}
+static void tegra_dma_synchronize(struct dma_chan *dc)
+{
+ struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
+
+ tasklet_kill(&tdc->tasklet);
+}
+
static unsigned int tegra_dma_sg_bytes_xferred(struct tegra_dma_channel *tdc,
struct tegra_dma_sg_req *sg_req)
{
@@ -1506,6 +1513,7 @@ static int tegra_dma_probe(struct platform_device *pdev)
tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
tdma->dma_dev.device_config = tegra_dma_slave_config;
tdma->dma_dev.device_terminate_all = tegra_dma_terminate_all;
+ tdma->dma_dev.device_synchronize = tegra_dma_synchronize;
tdma->dma_dev.device_tx_status = tegra_dma_tx_status;
tdma->dma_dev.device_issue_pending = tegra_dma_issue_pending;
--
2.24.0
next prev parent reply other threads:[~2019-12-29 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 14:55 [PATCH v2 00/12] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 01/12] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko
2019-12-29 14:55 ` Dmitry Osipenko [this message]
2019-12-29 14:55 ` [PATCH v2 03/12] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 04/12] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 05/12] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 06/12] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 07/12] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 08/12] dmaengine: tegra-apb: Remove runtime PM usage Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 09/12] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 10/12] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 11/12] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko
2019-12-29 14:55 ` [PATCH v2 12/12] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191229145525.533-3-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).