From: Vinod Koul <vkoul@kernel.org>
To: Gary R Hook <gary.hook@amd.com>, Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
kbuild test robot <lkp@intel.com>,
dan.j.williams@intel.com, Nehal-bakulchandra.Shah@amd.com,
Shyam-sundar.S-k@amd.com, davem@davemloft.net,
mchehab+samsung@kernel.org, robh@kernel.org,
Jonathan.Cameron@huawei.com, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dmaengine: ptdma: Initial driver for the AMD PassThru DMA engine
Date: Fri, 10 Jan 2020 13:27:07 +0530 [thread overview]
Message-ID: <20200110075707.GE2818@vkoul-mobl> (raw)
In-Reply-To: <20200103155256.GC1064304@kroah.com>
On 03-01-20, 16:52, Greg KH wrote:
> On Fri, Jan 03, 2020 at 09:12:18AM -0600, Gary R Hook wrote:
> > On 1/3/20 12:26 AM, Vinod Koul wrote:
> > > On 28-12-19, 07:56, kbuild test robot wrote:
> > > > Hi Sanjay,
> > > >
> > > > I love your patch! Perhaps something to improve:
> > >
> > > Please fix the issues reported and also make sure the patches sent are
> > > threaded, right now they are not and the series is all over my inbox :(
> > >
> >
> > What does this mean? The patches showed up in my inbox as a set of 3,
> > properly indexed, just like they should when sent with "git send-email".
> >
> > We've not had any reports from other lists/maintainers of similar problems.
> > So you'll understand how we might be a bit confused.
> >
> > Would you please elaborate on the problem you are seeing?
>
> There was no email threading of the patches, they all looked like
> individual emails. In other words, the "In-Reply-To:" value was not
> set.
And git send-email does that for you if you give it all the patches to
send to... If you give it each patch individually, they will come as
individual units
FWIW, my workflow is
$ git format-patch .... -o <some_dir>
<check the patches, add cover letter details etc>
$ git send-email <some_dir>
That ensures the In-Reply-To is set for subsequent patches and the log
will also tell you that
HTH
--
~Vinod
prev parent reply other threads:[~2020-01-10 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 14:47 [PATCH v2 1/3] dmaengine: ptdma: Initial driver for the AMD PassThru DMA engine Sanjay R Mehta
2019-12-27 23:56 ` kbuild test robot
2020-01-03 6:26 ` Vinod Koul
2020-01-03 11:33 ` Sanjay R Mehta
2020-01-03 15:12 ` Gary R Hook
2020-01-03 15:52 ` Greg KH
2020-01-10 7:57 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110075707.GE2818@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gary.hook@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox