From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com, geert@linux-m68k.org
Subject: Re: [PATCH v2 1/2] dmaengine: Cleanups for the slave <-> channel symlink support
Date: Mon, 3 Feb 2020 09:49:29 +0530 [thread overview]
Message-ID: <20200203041929.GM2841@vkoul-mobl> (raw)
In-Reply-To: <20200131093859.3311-2-peter.ujfalusi@ti.com>
On 31-01-20, 11:38, Peter Ujfalusi wrote:
> No need to use goto to jump over the
> return chan ? chan : ERR_PTR(-EPROBE_DEFER);
> We can just revert the check and return right there.
>
> Do not fail the channel request if the chan->name allocation fails, but
> print a warning about it.
>
> Change the dev_err to dev_warn if sysfs_create_link() fails as it is not
> fatal.
>
> Only attempt to remove the DMA_SLAVE_NAME symlink if it is created - or it
> was attempted to be created.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2020-02-03 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 9:38 [PATCH v2 0/2] dmaengine: Cleanups for symlink handling and debugfs support Peter Ujfalusi
2020-01-31 9:38 ` [PATCH v2 1/2] dmaengine: Cleanups for the slave <-> channel symlink support Peter Ujfalusi
2020-02-03 4:19 ` Vinod Koul [this message]
2020-01-31 9:38 ` [PATCH v2 2/2] dmaengine: Add basic debugfs support Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203041929.GM2841@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox