From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Subject: [PATCH] dmaengine: idxd: remove set but unused 'rc'
Date: Tue, 25 Feb 2020 13:44:59 +0530 [thread overview]
Message-ID: <20200225081459.4117512-1-vkoul@kernel.org> (raw)
The driver assigns result of check_vma() to rc and never checks the
result, so remove the assignment
drivers/dma/idxd/cdev.c: In function ‘idxd_cdev_mmap’:
drivers/dma/idxd/cdev.c:136:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
136 | int rc;
| ^~
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Dave, if you want the result of the check_vma() to be checked, feel free to
send the patch for that
drivers/dma/idxd/cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index 8dfdbe37e381..82b19eed6561 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -133,10 +133,9 @@ static int idxd_cdev_mmap(struct file *filp, struct vm_area_struct *vma)
struct pci_dev *pdev = idxd->pdev;
phys_addr_t base = pci_resource_start(pdev, IDXD_WQ_BAR);
unsigned long pfn;
- int rc;
dev_dbg(&pdev->dev, "%s called\n", __func__);
- rc = check_vma(wq, vma, __func__);
+ check_vma(wq, vma, __func__);
vma->vm_flags |= VM_DONTCOPY;
pfn = (base + idxd_get_wq_portal_full_offset(wq->id,
--
2.24.1
next reply other threads:[~2020-02-25 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 8:14 Vinod Koul [this message]
2020-02-25 16:14 ` [PATCH] dmaengine: idxd: remove set but unused 'rc' Dave Jiang
2020-02-28 6:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225081459.4117512-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox