DMA Engine development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Gary Hook <Gary.Hook@amd.com>
Subject: [PATCH v1 4/6] dmaengine: dmatest: Allow negative timeout value to specify infinite wait
Date: Fri, 24 Apr 2020 19:11:45 +0300	[thread overview]
Message-ID: <20200424161147.16895-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200424161147.16895-1-andriy.shevchenko@linux.intel.com>

The dmatest module parameter 'timeout' is documented as accepting a -1 to mean
"infinite timeout". However, an infinite timeout is not advised, nor possible
since the module parameter is an unsigned int, which won't accept a negative
value. Change the parameter type to be signed integer.

Cc: Gary Hook <Gary.Hook@amd.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/dmatest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index a521067751651..123b4bd41a085 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -60,7 +60,7 @@ MODULE_PARM_DESC(pq_sources,
 		"Number of p+q source buffers (default: 3)");
 
 static int timeout = 3000;
-module_param(timeout, uint, S_IRUGO | S_IWUSR);
+module_param(timeout, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), "
 		 "Pass -1 for infinite timeout");
 
-- 
2.26.2


  parent reply	other threads:[~2020-04-24 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 16:11 [PATCH v1 1/6] dmaengine: dmatest: Fix iteration non-stop logic Andy Shevchenko
2020-04-24 16:11 ` [PATCH v1 2/6] dmaengine: dmatest: Fix process hang when reading 'wait' parameter Andy Shevchenko
2020-04-27 16:16   ` Vinod Koul
2020-04-24 16:11 ` [PATCH v1 3/6] Revert "dmaengine: dmatest: timeout value of -1 should specify infinite wait" Andy Shevchenko
2020-04-27 16:18   ` Vinod Koul
2020-04-24 16:11 ` Andy Shevchenko [this message]
2020-04-27 16:18   ` [PATCH v1 4/6] dmaengine: dmatest: Allow negative timeout value to specify infinite wait Vinod Koul
2020-04-24 16:11 ` [PATCH v1 5/6] dmaengine: dmatest: Describe members of struct dmatest_params Andy Shevchenko
2020-04-27 16:21   ` Vinod Koul
2020-04-24 16:11 ` [PATCH v1 6/6] dmaengine: dmatest: Describe members of struct dmatest_info Andy Shevchenko
2020-04-27 16:22   ` Vinod Koul
2020-04-27  8:09 ` [PATCH v1 1/6] dmaengine: dmatest: Fix iteration non-stop logic Nicolas Ferre
2020-04-27 16:16 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424161147.16895-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Gary.Hook@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox