From: Vinod Koul <vkoul@kernel.org>
To: Alan Mikhak <alan.mikhak@sifive.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, gustavo.pimentel@synopsys.com,
dan.j.williams@intel.com, kishon@ti.com, maz@kernel.org,
paul.walmsley@sifive.com
Subject: Re: [PATCH v2][next] dmaengine: dw-edma: Check MSI descriptor before copying
Date: Mon, 27 Apr 2020 21:31:03 +0530 [thread overview]
Message-ID: <20200427160103.GF56386@vkoul-mobl.Dlink> (raw)
In-Reply-To: <1587607101-31914-1-git-send-email-alan.mikhak@sifive.com>
On 22-04-20, 18:58, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@sifive.com>
>
> Modify dw_edma_irq_request() to check if a struct msi_desc entry exists
> before copying the contents of its struct msi_msg pointer.
>
> Without this sanity check, __get_cached_msi_msg() crashes when invoked by
> dw_edma_irq_request() running on a Linux-based PCIe endpoint device. MSI
> interrupt are not received by PCIe endpoint devices. If irq_get_msi_desc()
> returns null, then there is no cached struct msi_msg to be copied.
>
> This patch depends on the following patch:
> [PATCH v2] dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci_dev
> https://patchwork.kernel.org/patch/11491757/
>
> Rebased on linux-next which has above patch applied.
These two para above should be added after s-o-b line as git-am skips
the lines after the marker. The above line are useful for applying but not
when applied. I have stripped these and applied the patch, thanks
--
~Vinod
prev parent reply other threads:[~2020-04-27 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 1:58 [PATCH v2][next] dmaengine: dw-edma: Check MSI descriptor before copying Alan Mikhak
2020-04-23 9:28 ` Gustavo Pimentel
2020-04-23 16:47 ` Alan Mikhak
2020-04-27 16:01 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427160103.GF56386@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alan.mikhak@sifive.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox