From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C15DC83004 for ; Tue, 28 Apr 2020 18:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 196D4208FE for ; Tue, 28 Apr 2020 18:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/xclh1S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbgD1SLU (ORCPT ); Tue, 28 Apr 2020 14:11:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgD1SLU (ORCPT ); Tue, 28 Apr 2020 14:11:20 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 095A1C03C1AB; Tue, 28 Apr 2020 11:11:20 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id x17so25051678wrt.5; Tue, 28 Apr 2020 11:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pNbfrC8rDwAuodGT5ERADsTbO3c/Vh/+yOTx050zhP0=; b=K/xclh1S/kFtxc6UOGpZ+ohiaD7ty92e3dKm/xP1/TH0BBWqs7VnN8DfQonVkL4LrR z97FnjzTTjTmw1BmsKafAH0wimcnu1ldTfNc3mB2FQuNclCM3RwwVWseZNzd9oAh+MAO 6tgBEwKFAl6hxYrHB9B2NdEH+SKkXgijB8Jk8ybjaYpm5oRkRB9GPm1iuTD4eNhRp+85 oA5/VJIqRAFHUjeONw1iWzw6FgB+F6l90cWxxh6M8KO33PgR9eJ4M9RaamZNqwH43GJk MIx4kyzg/4MaqEAyVJ/hx0oVqb0wDDxHWOUf6wMSFOOf4AlttB+VNiBZdaLM4Uq68ENB c2lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pNbfrC8rDwAuodGT5ERADsTbO3c/Vh/+yOTx050zhP0=; b=omBTjq6mEcZJkL9M+JLF8NXc5C+9XDjKCUIm1A+b6efZ/AltQv8zTbt8vX3Emirjyq 14zJjgzHbeCXedlUGO2GP6yRf2P4dQYqFbDrSiygK++jupAR4mqGWKmXpXgHtQzT2cGZ S5xqZBXrq/CDMrfirKSmnq9Y3pr4c7oQQyKZXVlyolJagbDnC8rNmCVx3RF2RVFt7G2H i1itYfIbp4+K6xAnNFelJWUe5u2HwnEuFWYGGjcIOaqeD1NogrxzXmqG5pYjxYjBZHbl IQl6qb7mlZLJu+c6+Tai9n3SEgGHxgJlxoy4lHUf7RmPoZnSafRAR2Y0OOkH3OgYTwoB HPTA== X-Gm-Message-State: AGi0Pubo1DvCMjM1YY+hYFdxIG8rnLtGxKSQHWA4zqybp90bYjeo5zX2 mZBiaL4jn3aZHgYnNIEy2lY= X-Google-Smtp-Source: APiQypL8UKoMHBWQyl5cCBVbP+wHnMT/zsA5PP+l/BLWEo4jEZLw6EGU/lInIUUUDbEuSCUlfGRsGw== X-Received: by 2002:a5d:54d0:: with SMTP id x16mr33042294wrv.86.1588097478728; Tue, 28 Apr 2020 11:11:18 -0700 (PDT) Received: from BV030612LT ([188.24.130.199]) by smtp.gmail.com with ESMTPSA id h188sm4610830wme.8.2020.04.28.11.11.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Apr 2020 11:11:18 -0700 (PDT) Date: Tue, 28 Apr 2020 21:11:15 +0300 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] dma: actions: Fix lockdep splat for owl-dma Message-ID: <20200428181115.GB26885@BV030612LT> References: <7d503c3dcac2b3ef29d4122a74eacfce142a8f98.1588069418.git.cristian.ciocaltea@gmail.com> <20200428164921.GC5259@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428164921.GC5259@Mani-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Tue, Apr 28, 2020 at 10:19:21PM +0530, Manivannan Sadhasivam wrote: > Hi, > > On Tue, Apr 28, 2020 at 01:56:12PM +0300, Cristian Ciocaltea wrote: > > When the kernel is build with lockdep support and the owl-dma driver is > > used, the following message is shown: > > > > [ 2.496939] INFO: trying to register non-static key. > > [ 2.501889] the code is fine but needs lockdep annotation. > > [ 2.507357] turning off the locking correctness validator. > > [ 2.512834] CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.6.3+ #15 > > [ 2.519084] Hardware name: Generic DT based system > > [ 2.523878] Workqueue: events_freezable mmc_rescan > > [ 2.528681] [<801127f0>] (unwind_backtrace) from [<8010da58>] (show_stack+0x10/0x14) > > [ 2.536420] [<8010da58>] (show_stack) from [<8080fbe8>] (dump_stack+0xb4/0xe0) > > [ 2.543645] [<8080fbe8>] (dump_stack) from [<8017efa4>] (register_lock_class+0x6f0/0x718) > > [ 2.551816] [<8017efa4>] (register_lock_class) from [<8017b7d0>] (__lock_acquire+0x78/0x25f0) > > [ 2.560330] [<8017b7d0>] (__lock_acquire) from [<8017e5e4>] (lock_acquire+0xd8/0x1f4) > > [ 2.568159] [<8017e5e4>] (lock_acquire) from [<80831fb0>] (_raw_spin_lock_irqsave+0x3c/0x50) > > [ 2.576589] [<80831fb0>] (_raw_spin_lock_irqsave) from [<8051b5fc>] (owl_dma_issue_pending+0xbc/0x120) > > [ 2.585884] [<8051b5fc>] (owl_dma_issue_pending) from [<80668cbc>] (owl_mmc_request+0x1b0/0x390) > > [ 2.594655] [<80668cbc>] (owl_mmc_request) from [<80650ce0>] (mmc_start_request+0x94/0xbc) > > [ 2.602906] [<80650ce0>] (mmc_start_request) from [<80650ec0>] (mmc_wait_for_req+0x64/0xd0) > > [ 2.611245] [<80650ec0>] (mmc_wait_for_req) from [<8065aa10>] (mmc_app_send_scr+0x10c/0x144) > > [ 2.619669] [<8065aa10>] (mmc_app_send_scr) from [<80659b3c>] (mmc_sd_setup_card+0x4c/0x318) > > [ 2.628092] [<80659b3c>] (mmc_sd_setup_card) from [<80659f0c>] (mmc_sd_init_card+0x104/0x430) > > [ 2.636601] [<80659f0c>] (mmc_sd_init_card) from [<8065a3e0>] (mmc_attach_sd+0xcc/0x16c) > > [ 2.644678] [<8065a3e0>] (mmc_attach_sd) from [<8065301c>] (mmc_rescan+0x3ac/0x40c) > > [ 2.652332] [<8065301c>] (mmc_rescan) from [<80143244>] (process_one_work+0x2d8/0x780) > > [ 2.660239] [<80143244>] (process_one_work) from [<80143730>] (worker_thread+0x44/0x598) > > [ 2.668323] [<80143730>] (worker_thread) from [<8014b5f8>] (kthread+0x148/0x150) > > [ 2.675708] [<8014b5f8>] (kthread) from [<801010b4>] (ret_from_fork+0x14/0x20) > > [ 2.682912] Exception stack(0xee8fdfb0 to 0xee8fdff8) > > [ 2.687954] dfa0: 00000000 00000000 00000000 00000000 > > [ 2.696118] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > [ 2.704277] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > The required fix is to use spin_lock_init() on the pchan lock before > > attempting to call any spin_lock_irqsave() in owl_dma_get_pchan(). > > > > Right, this is a bug. But while looking at the code now, I feel that we don't > need 'pchan->lock'. The idea was to protect 'pchan->vchan', but I think > 'od->lock' is the better candidate for that since it already protects it in > 'owl_dma_terminate_pchan'. > > So I'd be happy if you remove the lock from 'pchan' and just directly use the > one in 'od'. > > Out of curiosity, on which platform you're testing this? > > Thanks, > Mani > Hi Mani, Totally agree, I will send a new patch revision as soon as I do some more testing. I'm currently experimenting on an Actions S500 based board (Roseapple Pi) trying to extend, if possible, the existing mainline support for those SoCs. I don't have much progress so far, since I started quite recently and I also lack experience in the kernel development area, but I do my best to come back with more patches once I get a consistent functionality. Thanks a lot for your support, Cristi > > Signed-off-by: Cristian Ciocaltea > > --- > > drivers/dma/owl-dma.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > > index c683051257fd..d9d0f0488e70 100644 > > --- a/drivers/dma/owl-dma.c > > +++ b/drivers/dma/owl-dma.c > > @@ -1131,6 +1131,7 @@ static int owl_dma_probe(struct platform_device *pdev) > > > > pchan->id = i; > > pchan->base = od->base + OWL_DMA_CHAN_BASE(i); > > + spin_lock_init(&pchan->lock); > > } > > > > /* Init virtual channel */ > > -- > > 2.26.2 > >