From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9179C3A5A9 for ; Mon, 4 May 2020 05:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5C6E20735 for ; Mon, 4 May 2020 05:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588569442; bh=QMJaka9hkhKe4HxTAFmPhcwoBGA57avDfNSylKuJzJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sauNwPZ4ijNdkb2lYGoGaKIBxxvKCIatv3osNs9c0HcGVbWO67KnpjxXwLw9VX/Gv SFqeLX+F4TF86tlnQgAWkopEhiKIj9JEHDNSba3t1fdgANGGl0ZX8NAfaPApx91A3G +Kjs/Q/qH7ZBWOdXkiyqGXW3xKx1BTQ9mRNi1E5k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgEDFRW (ORCPT ); Mon, 4 May 2020 01:17:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:56266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbgEDFRW (ORCPT ); Mon, 4 May 2020 01:17:22 -0400 Received: from localhost (unknown [171.76.84.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09D60206C0; Mon, 4 May 2020 05:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588569441; bh=QMJaka9hkhKe4HxTAFmPhcwoBGA57avDfNSylKuJzJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qoo6s9hVzV239jyyhraX2UMI5kCViUyWSntUjdK7NowF27m9UImXLl//09mvREfg4 KraSsk65WoEknSXOgEObB4z3BzbvD6Dvbw1O8kKBZUPDbcLt6aBvmPVS9TNuP1RPeT Yw0rvrfwc7fzoIiebHLSDfMULSzim2kmG6eoeu4Q= Date: Mon, 4 May 2020 10:47:17 +0530 From: Vinod Koul To: Dave Jiang Cc: dmaengine@vger.kernel.org, sanjay.k.kumar@intel.com Subject: Re: [PATCH v2] dmaengine: idxd: fix interrupt completion after unmasking Message-ID: <20200504051717.GF1375924@vkoul-mobl> References: <158834641769.35613.1341160109892008587.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158834641769.35613.1341160109892008587.stgit@djiang5-desk3.ch.intel.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 01-05-20, 08:21, Dave Jiang wrote: > The current implementation may miss completions after we unmask the > interrupt. In order to make sure we process all competions, we need to: > 1. Do an MMIO read from the device as a barrier to ensure that all PCI > writes for completions have arrived. > 2. Check for any additional completions that we missed. Applied, thanks -- ~Vinod