From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F7BC433E0 for ; Tue, 19 May 2020 16:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7816E206BE for ; Tue, 19 May 2020 16:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589907397; bh=IupW7XaMJkYsAayJCAozFvTTvpKJWQQBm6o5U94IMBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=V1FpMwU7NtinOC8BkCJI6kGb4lCM0MSXfGSqxNGjl9Vl9pSrBTWfRqsE9jNhK6x5g vk6yjXJJT+8QVerlpmy1MJQkvUhjlMXO/Zqi/7CjeqhARUeQUw0Q06yYgOGsH1/Zxt 6A4Fhq8ObSuqeZSl2P/Z2Dts9EolzBo65FLEl3bg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729053AbgESQ4h (ORCPT ); Tue, 19 May 2020 12:56:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:60720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728689AbgESQ4h (ORCPT ); Tue, 19 May 2020 12:56:37 -0400 Received: from localhost (unknown [122.182.207.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB4C5204EA; Tue, 19 May 2020 16:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589907396; bh=IupW7XaMJkYsAayJCAozFvTTvpKJWQQBm6o5U94IMBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wpq3faH0UEduYmM5h1fBDkA1ZA33Iw8GA1bwkOTlaDqWlOFKRjHIf/6rQ48aDkK1I +Dxj/G8unzQ6VJFUkh67Ufvbwuha8uSsHCPutEYuiMgAP+uCT/C2s/VRCUr5lCEpjx EOaHnn7jg/+WwcL8rnnHQ2sQThRvMPaFB1uj4QJk= Date: Tue, 19 May 2020 22:26:32 +0530 From: Vinod Koul To: Christophe JAILLET Cc: ldewangan@nvidia.com, jonathanh@nvidia.com, dan.j.williams@intel.com, thierry.reding@gmail.com, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' Message-ID: <20200519165632.GQ374218@vkoul-mobl.Dlink> References: <20200516214205.276266-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516214205.276266-1-christophe.jaillet@wanadoo.fr> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 16-05-20, 23:42, Christophe JAILLET wrote: > Commit b53611fb1ce9 ("dmaengine: tegra210-adma: Fix crash during probe") > has moved some code in the probe function and reordered the error handling > path accordingly. > However, a goto has been missed. > > Fix it and goto the right label if 'dma_async_device_register()' fails, so > that all resources are released. Applied for fixes, thanks -- ~Vinod