From: Vinod Koul <vkoul@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: sh: usb-dmac: set tx_result parameters
Date: Wed, 24 Jun 2020 11:35:14 +0530 [thread overview]
Message-ID: <20200624060514.GC2324254@vkoul-mobl> (raw)
In-Reply-To: <1592482053-19433-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
On 18-06-20, 21:07, Yoshihiro Shimoda wrote:
> A client driver (renesas_usbhs) assumed that
> dmaengine_tx_status() could return the residue even if
> the transfer was completed. However, this was not correct
> usage [1] and this caused to break getting the residue after
> the commit 24461d9792c2 ("dmaengine: virt-dma: Fix access after
> free in vchan_complete()") actually. So, this is possible to get
> wrong received size if the usb controller gets a short packet.
> For example, g_zero driver causes "bad OUT byte" errors.
>
> To use the tx_result from the renesas_usbhs driver when
> the transfer is completed, set the tx_result parameters.
>
> Notes that the renesas_usbhs driver needs to update for it.
>
> [1]
> https://lore.kernel.org/dmaengine/20200616165550.GP2324254@vkoul-mobl/
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2020-06-24 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:07 [PATCH v2] dmaengine: sh: usb-dmac: set tx_result parameters Yoshihiro Shimoda
2020-06-24 6:05 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624060514.GC2324254@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox