From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5BCC433E1 for ; Fri, 17 Jul 2020 06:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F66220672 for ; Fri, 17 Jul 2020 06:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594965920; bh=ULhdOx89nRtmQeqBLFII5MBKJQMkkFOuD6QfOLh0eoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VB2waxMMtp5k+n/yKhdEf9lCMA+QYcjjQssfepO0iXWeijyaYXP7LvWYu/5BLGM7z cyVDDuN2mSUOP00nrIJcMiEqAHbYAlNj2xTzWNhRTBtG6LPuBdIZ5/GHWUvbrvIq1E LHJ4f3V7GwRb4l9roYT5lgAUipZBtUQ4UlxEuBpk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbgGQGFU (ORCPT ); Fri, 17 Jul 2020 02:05:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgGQGFU (ORCPT ); Fri, 17 Jul 2020 02:05:20 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2ADF2065E; Fri, 17 Jul 2020 06:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594965919; bh=ULhdOx89nRtmQeqBLFII5MBKJQMkkFOuD6QfOLh0eoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XhNsc8XX5SSMnOfFe9u+Wqdi/3fGCeiTjmoVw/h18HKRZIUEssmzq1prUigE7jeg4 N6a3VIyAfCUK972jx+XH2uc5vBfAtlrb4S7r3qLCcMahFo0YF/7Zc8VFy1RIBysZWB BfjUxyxKMqKbE3rqoLEo3izFm0nNs1Tj5UVyp2xc= Date: Fri, 17 Jul 2020 11:35:15 +0530 From: Vinod Koul To: Laurent Pinchart Cc: dmaengine@vger.kernel.org, Michal Simek , Hyun Kwon , Tejas Upadhyay , Satish Kumar Nagireddy , Peter Ujfalusi Subject: Re: [PATCH v7 4/5] dmaengine: xilinx: dpdma: Add debugfs support Message-ID: <20200717060515.GD82923@vkoul-mobl> References: <20200717013337.24122-1-laurent.pinchart@ideasonboard.com> <20200717013337.24122-5-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717013337.24122-5-laurent.pinchart@ideasonboard.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 17-07-20, 04:33, Laurent Pinchart wrote: > +static void xilinx_dpdma_debugfs_cleanup(struct xilinx_dpdma_device *xdev) > +{ > + debugfs_remove_recursive(xdev->debugfs_dir); you can skip this step as core will do so when you call dma_async_device_unregister() > + xdev->debugfs_dir = NULL; > +} > + > +static int xilinx_dpdma_debugfs_init(struct xilinx_dpdma_device *xdev) > +{ > + struct dentry *dent; > + > + dpdma_debugfs.testcase = DPDMA_TC_NONE; > + > + dent = debugfs_create_dir("dpdma", xdev->common.dbg_dev_root); > + if (IS_ERR(dent)) { > + dev_err(xdev->dev, "Failed to create debugfs directory\n"); > + return -ENODEV; > + } Do you really need another dir in your device root. You should already have .../dmaengine// adding dpdma dir seems overkill -- ~Vinod