From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8720BC433DF for ; Wed, 5 Aug 2020 20:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52C3B22CA1 for ; Wed, 5 Aug 2020 20:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596658154; bh=sLKCC1QjgtJmAuERFbBWWP9fB/9Lhbpc7SgboYEp2z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SBLPUACmA/RiCisMaBmOuVnVSAGRBuQSgqmO0jilxLnzWDffhhSYMcU7cObFbFaiL 0BEbloJ0l6ounDCziIMWFEYr3wMDy8f501eejhEqpl7+2fMq0OfGUkGZjjOtxof9gl f4IBBWkgsENPXdOH+j1Shyje8qaaPvZYtapPZ2K0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgHEUJD (ORCPT ); Wed, 5 Aug 2020 16:09:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:49488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbgHEQce (ORCPT ); Wed, 5 Aug 2020 12:32:34 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D03A322D71; Wed, 5 Aug 2020 13:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596633130; bh=sLKCC1QjgtJmAuERFbBWWP9fB/9Lhbpc7SgboYEp2z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qa76cu0k9JFT6Ep1vcMTDDSxNDUx8rkcmQTEoTyj2Yfn3MNeejXJcDLWqLr/2eprq LWlVGdOpwZX00VbkLmmoD0MsamOzJ0N9d1L6XIzhRmpVPel5+M9VurA4NaX0HJsSdU Vt1+jO3PBNqZWNu5eQAt9Hp5muY6A1tka5hysA3E= Date: Wed, 5 Aug 2020 18:42:05 +0530 From: Vinod Koul To: YueHaibing Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] dmaengine: iop-adma: Fix -Wint-to-pointer-cast build warning Message-ID: <20200805131205.GY12965@vkoul-mobl> References: <20200803141035.45284-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200803141035.45284-1-yuehaibing@huawei.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 03-08-20, 22:10, YueHaibing wrote: > drivers/dma/iop-adma.c:447:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > drivers/dma/iop-adma.c:449:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/dma/iop-adma.c:1301:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > Use void* for dma_desc_pool_virt, dma_addr_t for dma_desc_pool, > and use %pad to print dma_addr_t. > > Signed-off-by: YueHaibing > --- > drivers/dma/iop-adma.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c > index 3350bffb2e93..8e17e4405959 100644 > --- a/drivers/dma/iop-adma.c > +++ b/drivers/dma/iop-adma.c > @@ -415,7 +415,8 @@ static void iop_chan_start_null_xor(struct iop_adma_chan *iop_chan); > * */ > static int iop_adma_alloc_chan_resources(struct dma_chan *chan) > { > - char *hw_desc; > + void *hw_desc; > + dma_addr_t dma_desc; > int idx; > struct iop_adma_chan *iop_chan = to_iop_adma_chan(chan); > struct iop_adma_desc_slot *slot = NULL; > @@ -436,17 +437,16 @@ static int iop_adma_alloc_chan_resources(struct dma_chan *chan) > " %d descriptor slots", idx); > break; > } > - hw_desc = (char *) iop_chan->device->dma_desc_pool_virt; > - slot->hw_desc = (void *) &hw_desc[idx * IOP_ADMA_SLOT_SIZE]; > + hw_desc = iop_chan->device->dma_desc_pool_virt; > + slot->hw_desc = hw_desc + idx * IOP_ADMA_SLOT_SIZE; So you want to pointer arithmetic on a void pointer ! Are you sure math is correct here and will work on different compilers? > > dma_async_tx_descriptor_init(&slot->async_tx, chan); > slot->async_tx.tx_submit = iop_adma_tx_submit; > INIT_LIST_HEAD(&slot->tx_list); > INIT_LIST_HEAD(&slot->chain_node); > INIT_LIST_HEAD(&slot->slot_node); > - hw_desc = (char *) iop_chan->device->dma_desc_pool; > - slot->async_tx.phys = > - (dma_addr_t) &hw_desc[idx * IOP_ADMA_SLOT_SIZE]; > + dma_desc = iop_chan->device->dma_desc_pool; > + slot->async_tx.phys = dma_desc + idx * IOP_ADMA_SLOT_SIZE; > slot->idx = idx; > > spin_lock_bh(&iop_chan->lock); > @@ -1296,9 +1296,8 @@ static int iop_adma_probe(struct platform_device *pdev) > goto err_free_adev; > } > > - dev_dbg(&pdev->dev, "%s: allocated descriptor pool virt %p phys %p\n", > - __func__, adev->dma_desc_pool_virt, > - (void *) adev->dma_desc_pool); > + dev_dbg(&pdev->dev, "%s: allocated descriptor pool virt %p phys %pad\n", > + __func__, adev->dma_desc_pool_virt, &adev->dma_desc_pool); > > adev->id = plat_data->hw_id; > > -- > 2.17.1 > -- ~Vinod