Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static

Vinod Koul
2020-08-19T04:26:05Z

On 19-08-20, 02:41, Laurent Pinchart wrote:
> Hi Wei,
>
> Thank you for the patch.
>
> On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote:
> > The sparse tool complains as follows:
> >
> > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
> >
> > This variable is not used outside of xilinx_dpdma.c, so this commit
> > marks it static.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Looks good to me.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Vinod, could you pick this up as a v5.9 fix ?

This is not 5.9 fix. The debugfs patch will go into next for 5.10 so
this is applied to next as well

--
~Vinod