Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static

Laurent Pinchart
2020-08-18T23:41:30Z

Hi Wei,

Thank you for the patch.

On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
>
> This variable is not used outside of xilinx_dpdma.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Looks good to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Vinod, could you pick this up as a v5.9 fix ?

> ---
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 7db70d226e89..81ed1e482878 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args)
> }
>
> /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */
> -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> {
> .name = "DESCRIPTOR_DONE_INTR",
> .tc = DPDMA_TC_INTR_DONE,
>

--
Regards,

Laurent Pinchart