From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0ECC433E1 for ; Wed, 19 Aug 2020 04:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBED3207BB for ; Wed, 19 Aug 2020 04:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597811165; bh=Nt5fvzaUfAQQHR+uBcTqixdF6Qgj4u2fQgrV8+YVptM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rQEvk6JET+VXiwNvnNYMqTL0wdeFG41RPUVjir8pFHs7zHAtpNs26yvHMpgN8Z9yg PCgLTVTTytG61Ua1WDzamdbv8iY0oj6J78eP+Fo+lyMDLJqGdr0MELPilD3NtQ4jqv V3B4hmSYWI3eOwge4GA9GQx3qT2WZHlTHTeTvgxg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbgHSE0F (ORCPT ); Wed, 19 Aug 2020 00:26:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgHSE0F (ORCPT ); Wed, 19 Aug 2020 00:26:05 -0400 Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6DD420772; Wed, 19 Aug 2020 04:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597811164; bh=Nt5fvzaUfAQQHR+uBcTqixdF6Qgj4u2fQgrV8+YVptM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eTT8NCK5BBZKAcTdsIyUcBBVLfak93LlgZ99seQ5oODuO3la6Iqt48gIPN5pdB614 53R0avWN4i9W28gBL7t+ypPODwX/GbhNer/vEQc0GjvikdnozNf3BebfHtHVt+pT9W 46bWH5O9VeLg0DIkfFRV/toZsE/y2cA7ngZ1gTJE= Date: Wed, 19 Aug 2020 09:56:01 +0530 From: Vinod Koul To: Laurent Pinchart Cc: Wei Yongjun , Hulk Robot , Hyun Kwon , Michal Simek , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Message-ID: <20200819042601.GB2639@vkoul-mobl> References: <20200818112217.43816-1-weiyongjun1@huawei.com> <20200818234107.GC2360@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818234107.GC2360@pendragon.ideasonboard.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 19-08-20, 02:41, Laurent Pinchart wrote: > Hi Wei, > > Thank you for the patch. > > On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote: > > The sparse tool complains as follows: > > > > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning: > > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static? > > > > This variable is not used outside of xilinx_dpdma.c, so this commit > > marks it static. > > > > Reported-by: Hulk Robot > > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support") > > Signed-off-by: Wei Yongjun > > Looks good to me. > > Reviewed-by: Laurent Pinchart > > Vinod, could you pick this up as a v5.9 fix ? This is not 5.9 fix. The debugfs patch will go into next for 5.10 so this is applied to next as well -- ~Vinod