From: Vinod Koul <vkoul@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
b.zolnierkie@samsung.com
Subject: Re: [PATCH] dmaengine: pl330: fix instruction dump formatting
Date: Tue, 25 Aug 2020 16:41:41 +0530 [thread overview]
Message-ID: <20200825111141.GK2639@vkoul-mobl> (raw)
In-Reply-To: <20200813204123.19044-1-l.stelmach@samsung.com>
On 13-08-20, 22:41, Łukasz Stelmach wrote:
> Instruction dump uses two printk() in a row to print one instruction. Use
> KERN_CONT to prevent breaking the output in the middle.
Applied, thanks
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> drivers/dma/pl330.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 88b884cbb7c1..e1af6a470453 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -254,7 +254,7 @@ enum pl330_byteswap {
> static unsigned cmd_line;
> #define PL330_DBGCMD_DUMP(off, x...) do { \
> printk("%x:", cmd_line); \
> - printk(x); \
> + printk(KERN_CONT x); \
> cmd_line += off; \
> } while (0)
> #define PL330_DBGMC_START(addr) (cmd_line = addr)
> --
> 2.26.2
--
~Vinod
prev parent reply other threads:[~2020-08-25 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200813204151eucas1p1c64a0880ba83013f87d0ca41242e533a@eucas1p1.samsung.com>
2020-08-13 20:41 ` [PATCH] dmaengine: pl330: fix instruction dump formatting Łukasz Stelmach
2020-08-25 11:11 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825111141.GK2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox