From: Vinod Koul <vkoul@kernel.org>
To: Sanjay R Mehta <sanmehta@amd.com>
Cc: Sanjay R Mehta <Sanju.Mehta@amd.com>,
gregkh@linuxfoundation.org, dan.j.williams@intel.com,
Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com,
Nehal-bakulchandra.Shah@amd.com, robh@kernel.org,
mchehab+samsung@kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller
Date: Tue, 25 Aug 2020 16:46:59 +0530 [thread overview]
Message-ID: <20200825111659.GM2639@vkoul-mobl> (raw)
In-Reply-To: <19b20b55-0748-fb3c-755d-87ee6bdccf48@amd.com>
On 24-08-20, 13:11, Sanjay R Mehta wrote:
> Apologies for my delayed response.
>
> On 7/3/2020 12:48 PM, Vinod Koul wrote:
> > [CAUTION: External Email]
> >
> > On 16-06-20, 20:11, Sanjay R Mehta wrote:
> >
> >> +static int pt_core_execute_cmd(struct ptdma_desc *desc,
> >> + struct pt_cmd_queue *cmd_q)
> >> +{
> >> + __le32 *mp;
> >> + u32 *dp;
> >> + u32 tail;
> >> + int i;
> >
> > no tabs, spaces pls
> Sure, will fix in the next version of patch.
Also, please make sure you run checkpatch.pl with --strict option, that
will help out reducing the churn here
Thanks
--
~Vinod
next prev parent reply other threads:[~2020-08-25 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 1:11 [PATCH v5 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2020-06-17 1:11 ` [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller Sanjay R Mehta
2020-07-03 7:18 ` Vinod Koul
2020-08-24 7:41 ` Sanjay R Mehta
2020-08-25 11:16 ` Vinod Koul [this message]
2020-08-25 11:33 ` Sanjay R Mehta
2020-06-17 1:11 ` [PATCH v5 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource Sanjay R Mehta
2020-07-03 7:37 ` Vinod Koul
2020-08-24 11:13 ` Sanjay R Mehta
2020-06-17 1:11 ` [PATCH v5 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information Sanjay R Mehta
2020-07-03 7:42 ` Vinod Koul
2020-08-24 8:25 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825111659.GM2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
--cc=sanmehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox