From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C625AC433E2 for ; Fri, 28 Aug 2020 10:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2EA12137B for ; Fri, 28 Aug 2020 10:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598612345; bh=3OCUUvNXCZLjjiXdJrWQzv7L78aUQD2m17g1KMYVpGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EI1X6NoOPcD2cK0eln90bX4ZXuYDH19t+j/M7JCYYtJCqNWvKqGKT77kypLArWJ7F HZqHf76IWp7s4eEeYXOgciIFkbW2xdO+ER7BMQPv/3nDjjOSYZfV+KXN+obtJ8f7qx 1SiPPKCwQ4JbV7xr0zynucG8RD2M5Mz/7IAuQoWQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729051AbgH1K6x (ORCPT ); Fri, 28 Aug 2020 06:58:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729150AbgH1K4P (ORCPT ); Fri, 28 Aug 2020 06:56:15 -0400 Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4905C20B80; Fri, 28 Aug 2020 10:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598612136; bh=3OCUUvNXCZLjjiXdJrWQzv7L78aUQD2m17g1KMYVpGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1PouMkBRoj0w8gO85ZgkHlpUIgSYf30/U+c6WOtb9sUKzMe0Jjb2Db5tNDAaZSV+a cshLqkcfTFuMzWcVb2AZ9dHPOEEQF+qBj8tCwOWAj9mjrX5lbTx1adim+KagB/Icxn k0a2iQa6CAd2/ONqbbq54tHtq9XAfdHAlf5zjR7Y= Date: Fri, 28 Aug 2020 16:25:32 +0530 From: Vinod Koul To: Dave Jiang Cc: dmaengine@vger.kernel.org Subject: Re: [PATCH 2/2] dmaengine: idxd: add support for configurable max wq batch size Message-ID: <20200828105532.GV2639@vkoul-mobl> References: <159838710214.14812.7574610309412397859.stgit@djiang5-desk3.ch.intel.com> <159838710759.14812.4195210748462962591.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159838710759.14812.4195210748462962591.stgit@djiang5-desk3.ch.intel.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 25-08-20, 13:25, Dave Jiang wrote: > Add sysfs attribute max_batch_size to wq in order to allow the max batch > size configured on a per wq basis. Add support code to configure > the valid user input on wq enable. This is a performance tuning > parameter. > > Signed-off-by: Dave Jiang > --- > drivers/dma/idxd/device.c | 2 +- > drivers/dma/idxd/idxd.h | 1 + > drivers/dma/idxd/init.c | 1 + > drivers/dma/idxd/sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 41 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c > index b8dbb7001933..00dab1465ca3 100644 > --- a/drivers/dma/idxd/device.c > +++ b/drivers/dma/idxd/device.c > @@ -530,7 +530,7 @@ static int idxd_wq_config_write(struct idxd_wq *wq) > > /* bytes 12-15 */ > wq->wqcfg.max_xfer_shift = ilog2(wq->max_xfer_bytes); > - wq->wqcfg.max_batch_shift = idxd->hw.gen_cap.max_batch_shift; > + wq->wqcfg.max_batch_shift = ilog2(wq->max_batch_size); > > dev_dbg(dev, "WQ %d CFGs\n", wq->id); > for (i = 0; i < 8; i++) { > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h > index 81db2a472822..e8bec6eb9f7e 100644 > --- a/drivers/dma/idxd/idxd.h > +++ b/drivers/dma/idxd/idxd.h > @@ -115,6 +115,7 @@ struct idxd_wq { > struct dma_chan dma_chan; > char name[WQ_NAME_SIZE + 1]; > u64 max_xfer_bytes; > + u32 max_batch_size; > }; > > struct idxd_engine { > diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c > index e5ed5750a6d0..11e5ce168177 100644 > --- a/drivers/dma/idxd/init.c > +++ b/drivers/dma/idxd/init.c > @@ -177,6 +177,7 @@ static int idxd_setup_internals(struct idxd_device *idxd) > mutex_init(&wq->wq_lock); > wq->idxd_cdev.minor = -1; > wq->max_xfer_bytes = idxd->max_xfer_bytes; > + wq->max_batch_size = idxd->max_batch_size; > } > > for (i = 0; i < idxd->max_engines; i++) { > diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c > index 26b3ace66782..c5f19802cb9e 100644 > --- a/drivers/dma/idxd/sysfs.c > +++ b/drivers/dma/idxd/sysfs.c > @@ -1103,6 +1103,43 @@ static struct device_attribute dev_attr_wq_max_transfer_size = > __ATTR(max_transfer_size, 0644, > wq_max_transfer_size_show, wq_max_transfer_size_store); > > +static ssize_t wq_max_batch_size_show(struct device *dev, struct device_attribute *attr, char *buf) > +{ > + struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev); > + > + return sprintf(buf, "%u\n", wq->max_batch_size); > +} > + > +static ssize_t wq_max_batch_size_store(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev); > + struct idxd_device *idxd = wq->idxd; > + u32 batch_size; > + int rc; > + > + if (wq->state != IDXD_WQ_DISABLED) > + return -EPERM; > + > + rc = kstrtou32(buf, 10, &batch_size); > + if (rc < 0) > + return -EINVAL; > + > + if (batch_size == 0) > + return -EINVAL; seems quite similar to previous patch, maybe a helper to get the value? > + > + batch_size = roundup_pow_of_two(batch_size); > + if (batch_size > idxd->max_batch_size) > + return -EINVAL; > + > + wq->max_batch_size = batch_size; > + > + return count; > +} > + > +static struct device_attribute dev_attr_wq_max_batch_size = > + __ATTR(max_batch_size, 0644, wq_max_batch_size_show, wq_max_batch_size_store); > + > static struct attribute *idxd_wq_attributes[] = { > &dev_attr_wq_clients.attr, > &dev_attr_wq_state.attr, > @@ -1114,6 +1151,7 @@ static struct attribute *idxd_wq_attributes[] = { > &dev_attr_wq_name.attr, > &dev_attr_wq_cdev_minor.attr, > &dev_attr_wq_max_transfer_size.attr, > + &dev_attr_wq_max_batch_size.attr, ABI? > NULL, > }; > -- ~Vinod