From: Allen Pais <allen.lkml@gmail.com>
To: vkoul@kernel.org
Cc: linus.walleij@linaro.org, vireshk@kernel.org, leoyang.li@nxp.com,
zw@zh-kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
logang@deltatee.com, agross@kernel.org,
jorn.andersson@linaro.org, green.wan@sifive.com,
baohua@kernel.org, mripard@kernel.org, wens@csie.org,
dmaengine@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH v3 20/35] dmaengine: pl330: convert tasklets to use new tasklet_setup() API
Date: Mon, 31 Aug 2020 16:05:27 +0530 [thread overview]
Message-ID: <20200831103542.305571-21-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200831103542.305571-1-allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/dma/pl330.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 9b69716172a4..1e9a38139aa5 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1576,9 +1576,9 @@ static void dma_pl330_rqcb(struct dma_pl330_desc *desc, enum pl330_op_err err)
tasklet_schedule(&pch->task);
}
-static void pl330_dotask(unsigned long data)
+static void pl330_dotask(struct tasklet_struct *t)
{
- struct pl330_dmac *pl330 = (struct pl330_dmac *) data;
+ struct pl330_dmac *pl330 = from_tasklet(pl330, t, tasks);
unsigned long flags;
int i;
@@ -1982,7 +1982,7 @@ static int pl330_add(struct pl330_dmac *pl330)
return ret;
}
- tasklet_init(&pl330->tasks, pl330_dotask, (unsigned long) pl330);
+ tasklet_setup(&pl330->tasks, pl330_dotask);
pl330->state = INIT;
@@ -2065,9 +2065,9 @@ static inline void fill_queue(struct dma_pl330_chan *pch)
}
}
-static void pl330_tasklet(unsigned long data)
+static void pl330_tasklet(struct tasklet_struct *t)
{
- struct dma_pl330_chan *pch = (struct dma_pl330_chan *)data;
+ struct dma_pl330_chan *pch = from_tasklet(pch, t, task);
struct dma_pl330_desc *desc, *_dt;
unsigned long flags;
bool power_down = false;
@@ -2175,7 +2175,7 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
return -ENOMEM;
}
- tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
+ tasklet_setup(&pch->task, pl330_tasklet);
spin_unlock_irqrestore(&pl330->lock, flags);
--
2.25.1
next prev parent reply other threads:[~2020-08-31 10:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:35 [PATCH v3 00/35] dmaengine: convert tasklets to use new Allen Pais
2020-08-31 10:35 ` [PATCH v3 01/35] dmaengine: altera-msgdma: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-31 10:35 ` [PATCH v3 02/35] dmaengine: at_hdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 03/35] dmaengine: at_xdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 04/35] dmaengine: coh901318: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 05/35] dmaengine: dw: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 06/35] dmaengine: ep93xx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 07/35] dmaengine: fsl: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 08/35] dmaengine: imx-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 09/35] dmaengine: ioat: " Allen Pais
2020-08-31 14:47 ` Dave Jiang
2020-08-31 10:35 ` [PATCH v3 10/35] dmaengine: iop_adma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 11/35] dmaengine: ipu: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 12/35] dmaengine: k3dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 13/35] dmaengine: mediatek: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 14/35] dmaengine: mmp: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 15/35] dmaengine: mpc512x: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 16/35] dmaengine: mv_xor: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 17/35] dmaengine: mxs-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 18/35] dmaengine: nbpfaxi: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 19/35] dmaengine: pch_dma: " Allen Pais
2020-08-31 10:35 ` Allen Pais [this message]
2020-08-31 10:35 ` [PATCH v3 21/35] dmaengine: ppc4xx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 22/35] dmaengine: qcom: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 23/35] dmaengine: sa11x0: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 24/35] dmaengine: sirf-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 25/35] dmaengine: ste_dma40: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 26/35] dmaengine: sun6i: " Allen Pais
2020-08-31 11:23 ` Chen-Yu Tsai
2020-08-31 10:35 ` [PATCH v3 27/35] dmaengine: tegra20: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 28/35] dmaengine: timb_dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 29/35] dmaengine: txx9dmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 30/35] dmaengine: virt-dma: " Allen Pais
2020-08-31 11:30 ` Peter Ujfalusi
2020-08-31 10:35 ` [PATCH v3 31/35] dmaengine: xgene: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 32/35] dmaengine: xilinx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 33/35] dmaengine: plx_dma: " Allen Pais
2020-08-31 15:47 ` Logan Gunthorpe
2020-08-31 15:56 ` Allen
2020-08-31 16:17 ` Logan Gunthorpe
2020-08-31 10:35 ` [PATCH v3 34/35] dmaengine: sf-pdma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 35/35] dmaengine: k3-udma: " Allen Pais
2020-08-31 11:30 ` Peter Ujfalusi
2020-09-18 6:52 ` [PATCH v3 00/35] dmaengine: convert tasklets to use new Vinod Koul
2020-09-21 5:54 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831103542.305571-21-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=agross@kernel.org \
--cc=baohua@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=jorn.andersson@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=logang@deltatee.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=romain.perier@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox