Re: [PATCH v1 3/3] dmaengine: dmatest: Return boolean result directly in filter()

Peter Ujfalusi
2020-09-17T09:51:16Z

Hi Andy,

On 16/09/2020 16.34, Andy Shevchenko wrote:
> There is no need to have a conditional for boolean expression when
> function returns bool. Drop unnecessary code and return boolean
> result directly.
>
> While at it, drop unneeded casting from void *.

my test scripts are working fine with the three patch applied.

Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Vinod: for all three patches ^^

Andy, Vladimir: thanks for the fixes!

- Péter

> Cc: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/dmatest.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 757eb1727a04..cf1379189316 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -1070,13 +1070,7 @@ static int dmatest_add_channel(struct dmatest_info *info,
>
> static bool filter(struct dma_chan *chan, void *param)
> {
> - struct dmatest_params *params = param;
> -
> - if (!dmatest_match_channel(params, chan) ||
> - !dmatest_match_device(params, chan->device))
> - return false;
> - else
> - return true;
> + return dmatest_match_channel(param, chan) && dmatest_match_device(param, chan->device);
> }
>
> static void request_channels(struct dmatest_info *info,
>

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki