From: Liu Shixin <liushixin2@huawei.com>
To: Green Wan <green.wan@sifive.com>, Vinod Koul <vkoul@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Liu Shixin <liushixin2@huawei.com>
Subject: [PATCH -next] dmaengine: sf-pdma: Remove set but not used variable "desc"
Date: Thu, 17 Sep 2020 15:17:56 +0800 [thread overview]
Message-ID: <20200917071756.1915449-1-liushixin2@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
After commit 8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice"),
variable 'desc' is never used. Remove it to avoid build warning.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/dma/sf-pdma/sf-pdma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 754994087e5f..1e66c6990d81 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -284,7 +284,6 @@ static void sf_pdma_free_desc(struct virt_dma_desc *vdesc)
static void sf_pdma_donebh_tasklet(unsigned long arg)
{
struct sf_pdma_chan *chan = (struct sf_pdma_chan *)arg;
- struct sf_pdma_desc *desc = chan->desc;
unsigned long flags;
spin_lock_irqsave(&chan->lock, flags);
--
2.25.1
next reply other threads:[~2020-09-17 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 7:17 Liu Shixin [this message]
2020-09-18 7:10 ` [PATCH -next] dmaengine: sf-pdma: Remove set but not used variable "desc" Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917071756.1915449-1-liushixin2@huawei.com \
--to=liushixin2@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox