From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEBDC433E2 for ; Thu, 17 Sep 2020 11:22:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E79120771 for ; Thu, 17 Sep 2020 11:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600341748; bh=alahQ8Etr15Ff3L++TiTdgtdIGmaE5wLSVhlcoflxFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=q57tX/pcUhG/rdK/UXtQsyCWe1VrQB8cLITbKKujqJgB1eO5kW1WKS5HPwDe1upb2 /RYQGip4yQa1GBfZKpbDqnXyTfeWB400TJlMzpQI9zlUNxMv6Sw0Ggvs4jEalehObu 95/EeutB8gW6zf3Nqxx1e94m/mWhd+qHNV1QTLYE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgIQLWL (ORCPT ); Thu, 17 Sep 2020 07:22:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:45798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbgIQLWG (ORCPT ); Thu, 17 Sep 2020 07:22:06 -0400 Received: from localhost (unknown [136.185.111.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B49F221655; Thu, 17 Sep 2020 11:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600341718; bh=alahQ8Etr15Ff3L++TiTdgtdIGmaE5wLSVhlcoflxFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bCZV/VURIVxL/UU8ySNM/zmdxuZZVrUFoEkfHhtpYmVPJ+OzGPZtjOfRkwR97E3Tz S8IowtqqC0ler49zuR38yczySGcf+r1OU4pkjDefbULLQCO9gPWCkvk15PSMJ/26By m3yR1j+4MyHBIinq4H8Mq/p+Y5/N4SBMQWlDM1B4= Date: Thu, 17 Sep 2020 16:51:54 +0530 From: Vinod Koul To: Qilong Zhang Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org Subject: Re: [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname Message-ID: <20200917112154.GA2968@vkoul-mobl> References: <20200917074457.52748-1-zhangqilong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917074457.52748-1-zhangqilong3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 17-09-20, 15:44, Qilong Zhang wrote: > From: Zhang Qilong > > Use the devm_platform_ioremap_resource_byname() helper instead of > calling platform_get_resource_byname() and devm_ioremap_resource() > separately. > > Signed-off-by: Zhang Qilong > --- > drivers/dma/ti/k3-udma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > index de7bfc02a2de..eb29fdc9ffc1 100644 > --- a/drivers/dma/ti/k3-udma.c > +++ b/drivers/dma/ti/k3-udma.c > @@ -3157,13 +3157,11 @@ static const struct soc_device_attribute k3_soc_devices[] = { > > static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud) > { > - struct resource *res; > int i; > > for (i = 0; i < MMR_LAST; i++) { > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - mmr_names[i]); > - ud->mmrs[i] = devm_ioremap_resource(&pdev->dev, res); > + ud->mmrs[i] = devm_platform_ioremap_resource_byname(pdev, > + mmr_names[i]); One line please ;) > if (IS_ERR(ud->mmrs[i])) > return PTR_ERR(ud->mmrs[i]); > } > -- > 2.17.1 -- ~Vinod