From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995CEC43464 for ; Fri, 18 Sep 2020 07:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5653D2176B for ; Fri, 18 Sep 2020 07:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600414608; bh=tMJIGp6t8urEiQ2aBUoOKPVUceqzRsigcnMd9YF0FSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Cy4ZZ/o4HFmidmgsKUS10YNXg0o7mc5iSes3ABCQyLrluaZs4C48/HnSGlPZiXctN OgvT2H1PCy8yMbtDuCJIJix4eFD2Ig9PohHj8v9veNdwvXEM+1uQxMRVR6ELmObJy2 kKenx/SdoJYtIVLiXQU7lE7RvEe/uFPJGdmuDBO0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbgIRHgs (ORCPT ); Fri, 18 Sep 2020 03:36:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:60494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgIRHgr (ORCPT ); Fri, 18 Sep 2020 03:36:47 -0400 Received: from localhost (unknown [136.185.124.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67993208C3; Fri, 18 Sep 2020 07:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600414607; bh=tMJIGp6t8urEiQ2aBUoOKPVUceqzRsigcnMd9YF0FSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tEZ+KEuD3hZrmbk53MT3WkYUZ9D1Ogv5S65S4pQb9gtOHaOmFSs+TcVWHG1e0/PK6 zDWVIzHc81iurFyMFWs3HjGuWrS2JuCmn+eDR4GXQVNWXGh4IdgtfW4AcMgIxTkyRb +EQVhc1QbK5YWPeBvPXr7nWrO2+ul9LTxdrdqBLM= Date: Fri, 18 Sep 2020 13:06:43 +0530 From: Vinod Koul To: Grygorii Strashko Cc: Peter Ujfalusi , dmaengine@vger.kernel.org, Sekhar Nori , linux-kernel@vger.kernel.org, Vignesh Raghavendra Subject: Re: [PATCH v2] dmaengine: ti: k3-udma-glue: fix channel enable functions Message-ID: <20200918073643.GM2968@vkoul-mobl> References: <20200916120955.7963-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916120955.7963-1-grygorii.strashko@ti.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 16-09-20, 15:09, Grygorii Strashko wrote: > Now the K3 UDMA glue layer enable functions perform RMW operation on UDMA > RX/TX RT_CTL registers to set EN bit and enable channel, which is > incorrect, because only EN bit has to be set in those registers to enable > channel (all other bits should be cleared 0). > More over, this causes issues when bootloader leaves UDMA channel RX/TX > RT_CTL registers in incorrect state - TDOWN bit set, for example. As > result, UDMA channel will just perform teardown right after it's enabled. > > Hence, fix it by writing correct values (EN=1) directly in UDMA channel > RX/TX RT_CTL registers in k3_udma_glue_enable_tx/rx_chn() functions. Applied, thanks -- ~Vinod