From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Vladimir Murzin <vladimir.murzin@arm.com>
Subject: Re: [PATCH v1 3/3] dmaengine: dmatest: Return boolean result directly in filter()
Date: Tue, 22 Sep 2020 14:51:09 +0300 [thread overview]
Message-ID: <20200922115109.GP3956970@smile.fi.intel.com> (raw)
In-Reply-To: <5d865914-5481-0fe8-55d1-0c8efb6c481a@ti.com>
On Thu, Sep 17, 2020 at 12:39:27PM +0300, Peter Ujfalusi wrote:
> On 16/09/2020 16.34, Andy Shevchenko wrote:
> > There is no need to have a conditional for boolean expression when
> > function returns bool. Drop unnecessary code and return boolean
> > result directly.
> >
> > While at it, drop unneeded casting from void *.
>
> my test scripts are working fine with the three patch applied.
>
> Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Vinod: for all three patches ^^
>
> Andy, Vladimir: thanks for the fixes!
Thanks for testing! I'll apply your tag to v2 (assuming you are okay with
slight changes Vinod requested).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-22 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 13:34 [PATCH v1 1/3] dmaengine: dmatest: Fix regression when run command on misconfigured channel Andy Shevchenko
2020-09-16 13:34 ` [PATCH v1 2/3] dmaengine: dmatest: Check list for emptiness before access its last entry Andy Shevchenko
2020-09-16 13:34 ` [PATCH v1 3/3] dmaengine: dmatest: Return boolean result directly in filter() Andy Shevchenko
2020-09-17 9:39 ` Peter Ujfalusi
2020-09-22 11:51 ` Andy Shevchenko [this message]
2020-09-17 10:30 ` [PATCH v1 1/3] dmaengine: dmatest: Fix regression when run command on misconfigured channel Vinod Koul
2020-09-22 11:47 ` Andy Shevchenko
2020-09-22 11:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922115109.GP3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox