Re: [PATCH v6 4/5] dmaengine: idxd: Clean up descriptors with fault error

Vinod Koul
2020-10-05T05:45:57Z

On 04-10-20, 21:55, Dave Jiang wrote:
> > > +static bool process_fault(struct idxd_desc *desc, u64 fault_addr)
> > > +{
> > > + if ((u64)desc->hw == fault_addr ||
> > > + (u64)desc->completion == fault_addr) {
> >
> > you are casting descriptor address and completion, I can understand
> > former, but later..? Can you explain this please
> >
>
> It is possible to fail on the completion writeback address if the completion
> address programmed into the descriptor is bad.

Okay thanks for clarifying, maybe would help to add a comment.

--
~Vinod