Re: [PATCH v6 3/5] dmaengine: idxd: Add shared workqueue support

Vinod Koul
2020-10-05T04:35:16Z

On 24-09-20, 11:00, Dave Jiang wrote:

> @@ -1154,6 +1268,8 @@ static struct attribute *idxd_wq_attributes[] = {
> &dev_attr_wq_mode.attr,
> &dev_attr_wq_size.attr,
> &dev_attr_wq_priority.attr,
> + &dev_attr_wq_block_on_fault.attr,
> + &dev_attr_wq_threshold.attr,
> &dev_attr_wq_type.attr,
> &dev_attr_wq_name.attr,
> &dev_attr_wq_cdev_minor.attr,
> @@ -1305,6 +1421,16 @@ static ssize_t clients_show(struct device *dev,
> }
> static DEVICE_ATTR_RO(clients);
>
> +static ssize_t pasid_enabled_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct idxd_device *idxd =
> + container_of(dev, struct idxd_device, conf_dev);
> +
> + return sprintf(buf, "%u\n", device_pasid_enabled(idxd));
> +}
> +static DEVICE_ATTR_RO(pasid_enabled);
> +
> static ssize_t state_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -1424,6 +1550,7 @@ static struct attribute *idxd_device_attributes[] = {
> &dev_attr_gen_cap.attr,
> &dev_attr_configurable.attr,
> &dev_attr_clients.attr,
> + &dev_attr_pasid_enabled.attr,

No Documentation again for these new files! Please add them as well

--
~Vinod