Re: [PATCH] dmaengine: fsl: remove bad channel update

Allen
2020-10-06T05:04:01Z

> Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new
> tasklet_setup() API") broke this driver by not removing the old channel
> update method.
>
> Fix this by remove the offending call as channel is queried from
> tasklet structure.
>
> Fixes: 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/dma/fsl_raid.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 1ddd7cee2e7a..fdf3500d96a9 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
> @@ -163,8 +163,6 @@ static void fsl_re_dequeue(struct tasklet_struct *t)
> unsigned int count, oub_count;
> int found;
>
> - re_chan = dev_get_drvdata((struct device *)data);
> -
> fsl_re_cleanup_descs(re_chan);
>
> spin_lock_irqsave(&re_chan->desc_lock, flags);
> --
> 2.26.2
>

Thank you.

--
- Allen