From: Vinod Koul <vkoul@kernel.org>
To: Surendran K <surendran.k@samsung.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
shaik.ameer@samsung.com, alim.akhtar@samsung.com,
pankaj.dubey@samsung.com
Subject: Re: [PATCH] DMA: PL330: Remove unreachable code
Date: Wed, 14 Oct 2020 10:09:33 +0530 [thread overview]
Message-ID: <20201014043933.GQ2968@vkoul-mobl> (raw)
In-Reply-To: <20201013114713.28754-1-surendran.k@samsung.com>
On 13-10-20, 17:17, Surendran K wrote:
> _setup_req(..) never returns negative value.
> Hence the condition ret < 0 is never met
The subsystem is "dmaengine", git log would tell you the tags to use
>
> Signed-off-by: Surendran K <surendran.k@samsung.com>
> ---
> drivers/dma/pl330.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index e9f0101d92fa..8355586c9788 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1527,8 +1527,6 @@ static int pl330_submit_req(struct pl330_thread *thrd,
>
> /* First dry run to check if req is acceptable */
> ret = _setup_req(pl330, 1, thrd, idx, &xs);
> - if (ret < 0)
> - goto xfer_exit;
>
> if (ret > pl330->mcbufsz / 2) {
> dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz (%i/%i)\n",
> --
> 2.17.1
--
~Vinod
next prev parent reply other threads:[~2020-10-14 4:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201013122030epcas5p2e576d5a2ebfaf9df8078e6ee70f3765c@epcas5p2.samsung.com>
2020-10-13 11:47 ` [PATCH] DMA: PL330: Remove unreachable code Surendran K
2020-10-14 4:39 ` Vinod Koul [this message]
2020-10-16 10:30 ` Surendran K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014043933.GQ2968@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=shaik.ameer@samsung.com \
--cc=surendran.k@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox