public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/4] dmaengine: move struct in interface to use peripheral term
Date: Tue, 27 Oct 2020 22:46:01 +0530	[thread overview]
Message-ID: <20201027171601.GC3550@vkoul-mobl> (raw)
In-Reply-To: <61417567-e42a-789a-6848-acc84008cd45@ti.com>

On 19-10-20, 12:04, Peter Ujfalusi wrote:
> Hi Vinod,
> 
> one minor comment...
> 
> On 15/10/2020 10.31, Vinod Koul wrote:
> > dmaengine history has a non inclusive terminology of dmaengine slave, I
> > feel it is time to replace that.
> > 
> > This moves structures in dmaengine interface with replacement of slave
> > to peripheral which is an appropriate term for dmaengine peripheral
> > devices
> > 
> > Since the change of name can break users, the new names have been added
> > with old structs kept as macro define for new names. Once the users have
> > been migrated, these macros will be dropped.
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> 
> ...
> 
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index f7f420876d21..04b993a5373c 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> 
> ...
> 
> >  /**
> > - * struct dma_slave_map - associates slave device and it's slave channel with
> > + * struct dma_peripheral_map - associates peripheral device and it's peripheral channel with
> >   * parameter to be used by a filter function
> >   * @devname: name of the device
> > - * @slave: slave channel name
> > + * @peripheral: peripheral channel name
> 
> I know that this is slave -> peripheral change, but would not be better
> to call this as 'channame'?

okay have made in chan_name

-- 
~Vinod

  reply	other threads:[~2020-10-27 17:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  7:31 [PATCH 0/4] dmaengine: use inclusive terminology Vinod Koul
2020-10-15  7:31 ` [PATCH 1/4] dmaengine: move enums in interface to use peripheral term Vinod Koul
2020-10-19  8:54   ` Peter Ujfalusi
2020-10-27 17:11     ` Vinod Koul
2020-10-15  7:31 ` [PATCH 2/4] dmaengine: move struct " Vinod Koul
2020-10-19  9:04   ` Peter Ujfalusi
2020-10-27 17:16     ` Vinod Koul [this message]
2020-10-15  7:31 ` [PATCH 3/4] dmaengine: move APIs " Vinod Koul
2020-10-19  9:17   ` Peter Ujfalusi
2020-10-28  4:33     ` Vinod Koul
2020-10-15  7:31 ` [PATCH 4/4] dmaengine: core: update " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027171601.GC3550@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox