From: Vinod Koul <vkoul@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: 周琰杰 <zhouyanjie@wanyeetech.com>,
Zubair.Kakakhel@imgtec.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
yanfei.li@ingenic.com, sernia.zhou@foxmail.com,
zhenwenjin@gmail.com
Subject: Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
Date: Wed, 18 Nov 2020 16:25:11 +0530 [thread overview]
Message-ID: <20201118105511.GM50232@vkoul-mobl> (raw)
In-Reply-To: <BQOKJQ.FNG5W5HD7VTG1@crapouillou.net>
On 10-11-20, 08:54, Paul Cercueil wrote:
> Hi Zhou,
>
> Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> a écrit :
> > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from
> > Ingenic.
> >
> > 周琰杰 (Zhou Yanjie) (2):
> > dt-bindings: dmaengine: Add JZ4775 bindings.
> > dt-bindings: dmaengine: Add X2000 bindings.
> >
> > include/dt-bindings/dma/jz4775-dma.h | 44 +++++++++++++++++++++++++++++
> > include/dt-bindings/dma/x2000-dma.h | 54
> > ++++++++++++++++++++++++++++++++++++
>
> If that's up to me, these macros aren't really needed, and you can put the
> values directly in the dma cells. This is done already in jz4740.dtsi,
> jz4725b.dtsi and jz4770.dtsi.
But that is not really nice, it is good to define these rather than put
numbers, the include/dt-bindings exists for this sole reason!
--
~Vinod
next prev parent reply other threads:[~2020-11-18 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 2/2] dt-bindings: dmaengine: Add X2000 bindings 周琰杰 (Zhou Yanjie)
2020-11-10 8:54 ` [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs Paul Cercueil
2020-11-18 10:55 ` Vinod Koul [this message]
2020-11-18 10:59 ` Paul Cercueil
2020-11-18 10:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118105511.GM50232@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox