From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
chenqiwu <chenqiwu@xiaomi.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: [PATCH 6/6] dmaengine: ti: drop of_match_ptr and mark of_device_id table as maybe unused
Date: Fri, 20 Nov 2020 17:23:03 +0100 [thread overview]
Message-ID: <20201120162303.482126-6-krzk@kernel.org> (raw)
In-Reply-To: <20201120162303.482126-1-krzk@kernel.org>
The driver can match only via the DT table so the main table should be
always used and the of_match_ptr does not have any sense (this also
allows ACPI matching via PRP0001, even though it is not relevant here).
The secondary match of_device_id tables (passed to of_match_node) should
be marked as maybe unused to fix compile testing (!CONFIG_OF on x86_64)
warnings:
drivers/dma/ti/dma-crossbar.c:125:34: warning:
‘ti_am335x_master_match’ defined but not used [-Wunused-const-variable=]
drivers/dma/ti/dma-crossbar.c:22:34: warning:
‘ti_dma_xbar_match’ defined but not used [-Wunused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/dma/ti/dma-crossbar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 4ba8fa5d9c36..71d24fc07c00 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -122,7 +122,7 @@ static void *ti_am335x_xbar_route_allocate(struct of_phandle_args *dma_spec,
return map;
}
-static const struct of_device_id ti_am335x_master_match[] = {
+static const struct of_device_id ti_am335x_master_match[] __maybe_unused = {
{ .compatible = "ti,edma3-tpcc", },
{},
};
@@ -292,7 +292,7 @@ static const u32 ti_dma_offset[] = {
[TI_XBAR_SDMA_OFFSET] = 1,
};
-static const struct of_device_id ti_dra7_master_match[] = {
+static const struct of_device_id ti_dra7_master_match[] __maybe_unused = {
{
.compatible = "ti,omap4430-sdma",
.data = &ti_dma_offset[TI_XBAR_SDMA_OFFSET],
@@ -460,7 +460,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev)
static struct platform_driver ti_dma_xbar_driver = {
.driver = {
.name = "ti-dma-crossbar",
- .of_match_table = of_match_ptr(ti_dma_xbar_match),
+ .of_match_table = ti_dma_xbar_match,
},
.probe = ti_dma_xbar_probe,
};
--
2.25.1
next prev parent reply other threads:[~2020-11-20 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 16:22 [PATCH 1/6] dmaengine: jz4780: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:22 ` [PATCH 2/6] dmaengine: dw-axi-dmac: " Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 3/6] dmaengine: mv_xor: " Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 4/6] dmaengine: sf: " Krzysztof Kozlowski
2020-11-20 16:23 ` [PATCH 5/6] dmaengine: stm32: mark of_device_id table as maybe unused Krzysztof Kozlowski
2020-11-20 16:23 ` Krzysztof Kozlowski [this message]
2020-11-24 17:32 ` [PATCH 1/6] dmaengine: jz4780: drop of_match_ptr from of_device_id table Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120162303.482126-6-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=chenqiwu@xiaomi.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox