* [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
@ 2020-11-19 23:55 ` Cristian Ciocaltea
2020-11-28 7:29 ` Manivannan Sadhasivam
` (2 more replies)
2020-11-19 23:55 ` [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Cristian Ciocaltea
` (2 subsequent siblings)
3 siblings, 3 replies; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:55 UTC (permalink / raw)
To: Rob Herring, Vinod Koul, Andreas Färber,
Manivannan Sadhasivam
Cc: dmaengine, devicetree, linux-arm-kernel, linux-actions,
linux-kernel
Add a new compatible string corresponding to the DMA controller found
in the S500 variant of the Actions Semi Owl SoCs family.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/owl-dma.yaml b/Documentation/devicetree/bindings/dma/owl-dma.yaml
index 256d62af2c64..f085f0e42d2c 100644
--- a/Documentation/devicetree/bindings/dma/owl-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/owl-dma.yaml
@@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
description: |
The OWL DMA is a general-purpose direct memory access controller capable of
- supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
- respectively.
+ supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
+ independent DMA channels for the S500 and S900 SoC variants.
maintainers:
- Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
@@ -22,6 +22,7 @@ properties:
enum:
- actions,s900-dma
- actions,s700-dma
+ - actions,s500-dma
reg:
maxItems: 1
--
2.29.2
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
@ 2020-11-28 7:29 ` Manivannan Sadhasivam
2020-11-28 7:29 ` Manivannan Sadhasivam
2020-12-07 22:11 ` Rob Herring
2 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28 7:29 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Vinod Koul, Andreas Färber, dmaengine,
devicetree, linux-arm-kernel, linux-actions, linux-kernel
On Fri, Nov 20, 2020 at 01:55:58AM +0200, Cristian Ciocaltea wrote:
> Add a new compatible string corresponding to the DMA controller found
> in the S500 variant of the Actions Semi Owl SoCs family.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/owl-dma.yaml b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> index 256d62af2c64..f085f0e42d2c 100644
> --- a/Documentation/devicetree/bindings/dma/owl-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> @@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
>
> description: |
> The OWL DMA is a general-purpose direct memory access controller capable of
> - supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
> - respectively.
> + supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
> + independent DMA channels for the S500 and S900 SoC variants.
>
> maintainers:
> - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> @@ -22,6 +22,7 @@ properties:
> enum:
> - actions,s900-dma
> - actions,s700-dma
> + - actions,s500-dma
>
> reg:
> maxItems: 1
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2020-11-28 7:29 ` Manivannan Sadhasivam
@ 2020-11-28 7:29 ` Manivannan Sadhasivam
2020-11-29 18:15 ` Cristian Ciocaltea
2020-12-07 22:11 ` Rob Herring
2 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28 7:29 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Vinod Koul, Andreas Färber, dmaengine,
devicetree, linux-arm-kernel, linux-actions, linux-kernel
On Fri, Nov 20, 2020 at 01:55:58AM +0200, Cristian Ciocaltea wrote:
> Add a new compatible string corresponding to the DMA controller found
> in the S500 variant of the Actions Semi Owl SoCs family.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> ---
> Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/owl-dma.yaml b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> index 256d62af2c64..f085f0e42d2c 100644
> --- a/Documentation/devicetree/bindings/dma/owl-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> @@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
>
> description: |
> The OWL DMA is a general-purpose direct memory access controller capable of
> - supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
> - respectively.
> + supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
> + independent DMA channels for the S500 and S900 SoC variants.
>
> maintainers:
> - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> @@ -22,6 +22,7 @@ properties:
> enum:
> - actions,s900-dma
> - actions,s700-dma
> + - actions,s500-dma
I think we should order the entries now...
>
> reg:
> maxItems: 1
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-11-28 7:29 ` Manivannan Sadhasivam
@ 2020-11-29 18:15 ` Cristian Ciocaltea
0 siblings, 0 replies; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-11-29 18:15 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Rob Herring, Vinod Koul, Andreas Färber, dmaengine,
devicetree, linux-arm-kernel, linux-actions, linux-kernel
On Sat, Nov 28, 2020 at 12:59:45PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 20, 2020 at 01:55:58AM +0200, Cristian Ciocaltea wrote:
> > Add a new compatible string corresponding to the DMA controller found
> > in the S500 variant of the Actions Semi Owl SoCs family.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> > Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/owl-dma.yaml b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> > index 256d62af2c64..f085f0e42d2c 100644
> > --- a/Documentation/devicetree/bindings/dma/owl-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/owl-dma.yaml
> > @@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
> >
> > description: |
> > The OWL DMA is a general-purpose direct memory access controller capable of
> > - supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
> > - respectively.
> > + supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
> > + independent DMA channels for the S500 and S900 SoC variants.
> >
> > maintainers:
> > - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > @@ -22,6 +22,7 @@ properties:
> > enum:
> > - actions,s900-dma
> > - actions,s700-dma
> > + - actions,s500-dma
>
> I think we should order the entries now...
Right, I will provide the reordered list in the upcoming revision.
> >
> > reg:
> > maxItems: 1
> > --
> > 2.29.2
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2020-11-28 7:29 ` Manivannan Sadhasivam
2020-11-28 7:29 ` Manivannan Sadhasivam
@ 2020-12-07 22:11 ` Rob Herring
2020-12-07 22:56 ` Cristian Ciocaltea
2 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2020-12-07 22:11 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: linux-actions, devicetree, linux-arm-kernel, Vinod Koul,
Manivannan Sadhasivam, dmaengine, linux-kernel,
Andreas Färber, Rob Herring
On Fri, 20 Nov 2020 01:55:58 +0200, Cristian Ciocaltea wrote:
> Add a new compatible string corresponding to the DMA controller found
> in the S500 variant of the Actions Semi Owl SoCs family.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> ---
> Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
2020-12-07 22:11 ` Rob Herring
@ 2020-12-07 22:56 ` Cristian Ciocaltea
0 siblings, 0 replies; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-12-07 22:56 UTC (permalink / raw)
To: Rob Herring
Cc: linux-actions, devicetree, linux-arm-kernel, Vinod Koul,
Manivannan Sadhasivam, dmaengine, linux-kernel,
Andreas Färber, Rob Herring
On Mon, Dec 07, 2020 at 04:11:07PM -0600, Rob Herring wrote:
> On Fri, 20 Nov 2020 01:55:58 +0200, Cristian Ciocaltea wrote:
> > Add a new compatible string corresponding to the DMA controller found
> > in the S500 variant of the Actions Semi Owl SoCs family.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> > Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks for reviewing,
Cristi
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
@ 2020-11-19 23:55 ` Cristian Ciocaltea
2020-11-28 7:30 ` Manivannan Sadhasivam
2020-11-19 23:56 ` [PATCH v2 06/18] arm: dts: owl-s500: Add " Cristian Ciocaltea
2020-12-05 6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
3 siblings, 1 reply; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:55 UTC (permalink / raw)
To: Vinod Koul, Dan Williams, Andreas Färber,
Manivannan Sadhasivam, Rob Herring
Cc: dmaengine, linux-arm-kernel, linux-actions, linux-kernel
The DMA controller present on the Actions Semi S500 SoC is compatible
with the S900 variant, so add it to the list of devices supported by
the Actions Semi Owl DMA driver.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
drivers/dma/owl-dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 9fede32641e9..54e509de66e2 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
static const struct of_device_id owl_dma_match[] = {
{ .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
{ .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
+ { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, owl_dma_match);
--
2.29.2
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller
2020-11-19 23:55 ` [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Cristian Ciocaltea
@ 2020-11-28 7:30 ` Manivannan Sadhasivam
2020-11-29 18:24 ` Cristian Ciocaltea
0 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28 7:30 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Vinod Koul, Dan Williams, Andreas Färber, Rob Herring,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel
On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote:
> The DMA controller present on the Actions Semi S500 SoC is compatible
> with the S900 variant, so add it to the list of devices supported by
> the Actions Semi Owl DMA driver.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
I hope that you have verified both Memcpy and Slave transfers...
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/dma/owl-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> index 9fede32641e9..54e509de66e2 100644
> --- a/drivers/dma/owl-dma.c
> +++ b/drivers/dma/owl-dma.c
> @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
> static const struct of_device_id owl_dma_match[] = {
> { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
> { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
> + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, owl_dma_match);
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller
2020-11-28 7:30 ` Manivannan Sadhasivam
@ 2020-11-29 18:24 ` Cristian Ciocaltea
2020-12-05 6:08 ` Manivannan Sadhasivam
0 siblings, 1 reply; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-11-29 18:24 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Vinod Koul, Dan Williams, Andreas Färber, Rob Herring,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel
On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote:
> > The DMA controller present on the Actions Semi S500 SoC is compatible
> > with the S900 variant, so add it to the list of devices supported by
> > the Actions Semi Owl DMA driver.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
>
> I hope that you have verified both Memcpy and Slave transfers...
I have been using 'dmatest' module as documented in:
https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html
I tested all the available channels and could not find any signs of
possible issues. Bellow is an excerpt from the kernel ring buffer:
[ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0)
[ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0)
[ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0)
Should I perform some additional tests?
Thanks,
Cristi
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
> > ---
> > drivers/dma/owl-dma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> > index 9fede32641e9..54e509de66e2 100644
> > --- a/drivers/dma/owl-dma.c
> > +++ b/drivers/dma/owl-dma.c
> > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
> > static const struct of_device_id owl_dma_match[] = {
> > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
> > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
> > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
> > { /* sentinel */ },
> > };
> > MODULE_DEVICE_TABLE(of, owl_dma_match);
> > --
> > 2.29.2
> >
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller
2020-11-29 18:24 ` Cristian Ciocaltea
@ 2020-12-05 6:08 ` Manivannan Sadhasivam
0 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-05 6:08 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Vinod Koul, Dan Williams, Andreas Färber, Rob Herring,
dmaengine, linux-arm-kernel, linux-actions, linux-kernel
On Sun, Nov 29, 2020 at 08:24:21PM +0200, Cristian Ciocaltea wrote:
> On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote:
> > On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote:
> > > The DMA controller present on the Actions Semi S500 SoC is compatible
> > > with the S900 variant, so add it to the list of devices supported by
> > > the Actions Semi Owl DMA driver.
> > >
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> >
> > I hope that you have verified both Memcpy and Slave transfers...
>
> I have been using 'dmatest' module as documented in:
> https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html
>
> I tested all the available channels and could not find any signs of
> possible issues. Bellow is an excerpt from the kernel ring buffer:
>
> [ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0)
> [ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0)
> [ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0)
>
> Should I perform some additional tests?
>
Nope, this is sufficient. Since you have tested slave transfer with MMC driver,
running dmatest for memcpy is fine.
Thanks,
Mani
> Thanks,
> Cristi
>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Thanks,
> > Mani
> >
> > > ---
> > > drivers/dma/owl-dma.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
> > > index 9fede32641e9..54e509de66e2 100644
> > > --- a/drivers/dma/owl-dma.c
> > > +++ b/drivers/dma/owl-dma.c
> > > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
> > > static const struct of_device_id owl_dma_match[] = {
> > > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
> > > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
> > > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
> > > { /* sentinel */ },
> > > };
> > > MODULE_DEVICE_TABLE(of, owl_dma_match);
> > > --
> > > 2.29.2
> > >
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 06/18] arm: dts: owl-s500: Add DMA controller
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2020-11-19 23:55 ` [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Cristian Ciocaltea
@ 2020-11-19 23:56 ` Cristian Ciocaltea
2020-11-28 7:31 ` Manivannan Sadhasivam
2020-12-05 6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
3 siblings, 1 reply; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:56 UTC (permalink / raw)
To: Andreas Färber, Manivannan Sadhasivam, Rob Herring,
Vinod Koul, Dan Williams
Cc: devicetree, dmaengine, linux-arm-kernel, linux-actions,
linux-kernel
Add DMA controller node for Actions Semi S500 SoC.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
index a57ce7d6d745..449e9807c4ec 100644
--- a/arch/arm/boot/dts/owl-s500.dtsi
+++ b/arch/arm/boot/dts/owl-s500.dtsi
@@ -207,5 +207,19 @@ sps: power-controller@b01b0100 {
reg = <0xb01b0100 0x100>;
#power-domain-cells = <1>;
};
+
+ dma: dma-controller@b0260000 {
+ compatible = "actions,s500-dma";
+ reg = <0xb0260000 0xd00>;
+ interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ dma-channels = <12>;
+ dma-requests = <46>;
+ clocks = <&cmu CLK_DMAC>;
+ power-domains = <&sps S500_PD_DMA>;
+ };
};
};
--
2.29.2
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v2 06/18] arm: dts: owl-s500: Add DMA controller
2020-11-19 23:56 ` [PATCH v2 06/18] arm: dts: owl-s500: Add " Cristian Ciocaltea
@ 2020-11-28 7:31 ` Manivannan Sadhasivam
0 siblings, 0 replies; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28 7:31 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Andreas Färber, Rob Herring, Vinod Koul, Dan Williams,
devicetree, dmaengine, linux-arm-kernel, linux-actions,
linux-kernel
On Fri, Nov 20, 2020 at 01:56:00AM +0200, Cristian Ciocaltea wrote:
> Add DMA controller node for Actions Semi S500 SoC.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
> index a57ce7d6d745..449e9807c4ec 100644
> --- a/arch/arm/boot/dts/owl-s500.dtsi
> +++ b/arch/arm/boot/dts/owl-s500.dtsi
> @@ -207,5 +207,19 @@ sps: power-controller@b01b0100 {
> reg = <0xb01b0100 0x100>;
> #power-domain-cells = <1>;
> };
> +
> + dma: dma-controller@b0260000 {
> + compatible = "actions,s500-dma";
> + reg = <0xb0260000 0xd00>;
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + dma-channels = <12>;
> + dma-requests = <46>;
> + clocks = <&cmu CLK_DMAC>;
> + power-domains = <&sps S500_PD_DMA>;
> + };
> };
> };
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
` (2 preceding siblings ...)
2020-11-19 23:56 ` [PATCH v2 06/18] arm: dts: owl-s500: Add " Cristian Ciocaltea
@ 2020-12-05 6:11 ` Manivannan Sadhasivam
2020-12-05 16:29 ` Cristian Ciocaltea
3 siblings, 1 reply; 15+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-05 6:11 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Andreas Färber, Vinod Koul, Wolfram Sang,
Ulf Hansson, Dan Williams, devicetree, linux-arm-kernel,
linux-actions, linux-kernel, dmaengine, linux-i2c, linux-mmc
Hi Cristi,
On Fri, Nov 20, 2020 at 01:55:54AM +0200, Cristian Ciocaltea wrote:
> Hi,
>
> This patchset brings a series of improvements for the Actions Semi S500
> SoCs family, by adding support for Clock & Reset Management Units, DMA,
> MMC, I2C & SIRQ controllers.
>
> Please note the patches consist mostly of DTS and bindings/compatibles
> changes, since all the work they depend on has been already merged,
> i.e. clock fixes/additions, pinctrl driver, sirq driver.
>
> For the moment, I have only enabled the features I could test on
> RoseapplePi SBC.
>
I was hoping to apply this series for v5.11 but we ran out of time. So expect
this series to be in v5.12.
Thanks,
Mani
> Thanks,
> Cristi
>
> Changes in v2:
> - Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
> - Added support for the SIRQ controller
> - Added new entries in MAINTAINERS
> - Updated naming of some patches in v1
>
> Cristian Ciocaltea (18):
> arm: dts: owl-s500: Add Clock Management Unit
> arm: dts: owl-s500: Set CMU clocks for UARTs
> arm: dts: owl-s500: Add Reset controller
> dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
> dmaengine: owl: Add compatible for the Actions Semi S500 DMA
> controller
> arm: dts: owl-s500: Add DMA controller
> arm: dts: owl-s500: Add pinctrl & GPIO support
> dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
> arm: dts: owl-s500: Add MMC support
> dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
> MAINTAINERS: Update entry for Actions Semi Owl I2C binding
> i2c: owl: Add compatible for the Actions Semi S500 I2C controller
> arm: dts: owl-s500: Add I2C support
> arm: dts: owl-s500: Add SIRQ controller
> arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
> arm: dts: owl-s500-roseapplepi: Add uSD support
> arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
> MAINTAINERS: Add linux-actions ML for Actions Semi Arch
>
> .../devicetree/bindings/dma/owl-dma.yaml | 5 +-
> .../devicetree/bindings/i2c/i2c-owl.txt | 29 ----
> .../devicetree/bindings/i2c/i2c-owl.yaml | 62 ++++++++
> .../devicetree/bindings/mmc/owl-mmc.yaml | 4 +-
> MAINTAINERS | 3 +-
> arch/arm/boot/dts/owl-s500-roseapplepi.dts | 97 +++++++++++-
> arch/arm/boot/dts/owl-s500.dtsi | 140 ++++++++++++++++++
> drivers/dma/owl-dma.c | 1 +
> drivers/i2c/busses/i2c-owl.c | 1 +
> 9 files changed, 304 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
>
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs
2020-12-05 6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
@ 2020-12-05 16:29 ` Cristian Ciocaltea
0 siblings, 0 replies; 15+ messages in thread
From: Cristian Ciocaltea @ 2020-12-05 16:29 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Rob Herring, Andreas Färber, Vinod Koul, Wolfram Sang,
Ulf Hansson, Dan Williams, devicetree, linux-arm-kernel,
linux-actions, linux-kernel, dmaengine, linux-i2c, linux-mmc
Hi Mani,
On Sat, Dec 05, 2020 at 11:41:15AM +0530, Manivannan Sadhasivam wrote:
> Hi Cristi,
>
> On Fri, Nov 20, 2020 at 01:55:54AM +0200, Cristian Ciocaltea wrote:
> > Hi,
> >
> > This patchset brings a series of improvements for the Actions Semi S500
> > SoCs family, by adding support for Clock & Reset Management Units, DMA,
> > MMC, I2C & SIRQ controllers.
> >
> > Please note the patches consist mostly of DTS and bindings/compatibles
> > changes, since all the work they depend on has been already merged,
> > i.e. clock fixes/additions, pinctrl driver, sirq driver.
> >
> > For the moment, I have only enabled the features I could test on
> > RoseapplePi SBC.
> >
>
> I was hoping to apply this series for v5.11 but we ran out of time. So expect
> this series to be in v5.12.
No problem, thanks a lot for taking care of this!
Kind regards,
Cristi
> Thanks,
> Mani
>
> > Thanks,
> > Cristi
> >
> > Changes in v2:
> > - Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
> > - Added support for the SIRQ controller
> > - Added new entries in MAINTAINERS
> > - Updated naming of some patches in v1
> >
> > Cristian Ciocaltea (18):
> > arm: dts: owl-s500: Add Clock Management Unit
> > arm: dts: owl-s500: Set CMU clocks for UARTs
> > arm: dts: owl-s500: Add Reset controller
> > dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
> > dmaengine: owl: Add compatible for the Actions Semi S500 DMA
> > controller
> > arm: dts: owl-s500: Add DMA controller
> > arm: dts: owl-s500: Add pinctrl & GPIO support
> > dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
> > arm: dts: owl-s500: Add MMC support
> > dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
> > MAINTAINERS: Update entry for Actions Semi Owl I2C binding
> > i2c: owl: Add compatible for the Actions Semi S500 I2C controller
> > arm: dts: owl-s500: Add I2C support
> > arm: dts: owl-s500: Add SIRQ controller
> > arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
> > arm: dts: owl-s500-roseapplepi: Add uSD support
> > arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
> > MAINTAINERS: Add linux-actions ML for Actions Semi Arch
> >
> > .../devicetree/bindings/dma/owl-dma.yaml | 5 +-
> > .../devicetree/bindings/i2c/i2c-owl.txt | 29 ----
> > .../devicetree/bindings/i2c/i2c-owl.yaml | 62 ++++++++
> > .../devicetree/bindings/mmc/owl-mmc.yaml | 4 +-
> > MAINTAINERS | 3 +-
> > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 97 +++++++++++-
> > arch/arm/boot/dts/owl-s500.dtsi | 140 ++++++++++++++++++
> > drivers/dma/owl-dma.c | 1 +
> > drivers/i2c/busses/i2c-owl.c | 1 +
> > 9 files changed, 304 insertions(+), 38 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
> > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> >
> > --
> > 2.29.2
> >
^ permalink raw reply [flat|nested] 15+ messages in thread