From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vkoul@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>,
<robh+dt@kernel.org>
Cc: <dan.j.williams@intel.com>, <t-kristo@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<dmaengine@vger.kernel.org>, <vigneshr@ti.com>,
<grygorii.strashko@ti.com>
Subject: [PATCH v3 06/20] dmaengine: ti: k3-udma-glue: Configure the dma_dev for rings
Date: Tue, 8 Dec 2020 11:04:26 +0200 [thread overview]
Message-ID: <20201208090440.31792-7-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20201208090440.31792-1-peter.ujfalusi@ti.com>
Rings in RING mode should be using the DMA device for DMA API as in this
mode the ringacc will not access the ring memory in any ways, but the DMA
is.
Fix up the ring configuration and set the dma_dev unconditionally and let
the ringacc driver to select the correct device to use for DMA API.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/ti/k3-udma-glue.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
index 8a8988be4175..e6ebcd98c02a 100644
--- a/drivers/dma/ti/k3-udma-glue.c
+++ b/drivers/dma/ti/k3-udma-glue.c
@@ -276,6 +276,10 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
goto err;
}
+ /* Set the dma_dev for the rings to be configured */
+ cfg->tx_cfg.dma_dev = k3_udma_glue_tx_get_dma_device(tx_chn);
+ cfg->txcq_cfg.dma_dev = cfg->tx_cfg.dma_dev;
+
ret = k3_ringacc_ring_cfg(tx_chn->ringtx, &cfg->tx_cfg);
if (ret) {
dev_err(dev, "Failed to cfg ringtx %d\n", ret);
@@ -591,6 +595,10 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
goto err_rflow_put;
}
+ /* Set the dma_dev for the rings to be configured */
+ flow_cfg->rx_cfg.dma_dev = k3_udma_glue_rx_get_dma_device(rx_chn);
+ flow_cfg->rxfdq_cfg.dma_dev = flow_cfg->rx_cfg.dma_dev;
+
ret = k3_ringacc_ring_cfg(flow->ringrx, &flow_cfg->rx_cfg);
if (ret) {
dev_err(dev, "Failed to cfg ringrx %d\n", ret);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-12-08 9:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 9:04 [PATCH v3 00/20] dmaengine/soc: k3-udma: Add support for BCDMA and PKTDMA Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 01/20] dmaengine: ti: k3-udma: Correct normal channel offset when uchan_cnt is not 0 Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 02/20] dmaengine: ti: k3-udma: Wait for peer teardown completion if supported Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 03/20] dmaengine: ti: k3-udma: Add support for second resource range from sysfw Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 04/20] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API Peter Ujfalusi
2020-12-08 11:52 ` Grygorii Strashko
2020-12-08 9:04 ` [PATCH v3 05/20] dmaengine: ti: k3-udma-glue: Get the ringacc from udma_dev Peter Ujfalusi
2020-12-08 11:52 ` Grygorii Strashko
2020-12-08 9:04 ` Peter Ujfalusi [this message]
2020-12-08 11:53 ` [PATCH v3 06/20] dmaengine: ti: k3-udma-glue: Configure the dma_dev for rings Grygorii Strashko
2020-12-08 9:04 ` [PATCH v3 07/20] dmaengine: of-dma: Add support for optional router configuration callback Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 08/20] dmaengine: Add support for per channel coherency handling Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 09/20] dmaengine: doc: client: Update for dmaengine_get_dma_device() usage Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 10/20] dmaengine: dmatest: Use dmaengine_get_dma_device Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 11/20] dt-bindings: dma: ti: Add document for K3 BCDMA Peter Ujfalusi
2020-12-10 13:59 ` Rob Herring
2020-12-08 9:04 ` [PATCH v3 12/20] dt-bindings: dma: ti: Add document for K3 PKTDMA Peter Ujfalusi
2020-12-10 14:00 ` Rob Herring
2020-12-08 9:04 ` [PATCH v3 13/20] dmaengine: ti: k3-psil: Extend psil_endpoint_config " Peter Ujfalusi
2020-12-08 11:55 ` Grygorii Strashko
2020-12-08 9:04 ` [PATCH v3 14/20] dmaengine: ti: k3-psil: Add initial map for AM64 Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 15/20] dmaengine: ti: Add support for k3 event routers Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 16/20] soc: ti: k3-ringacc: add AM64 DMA rings support Peter Ujfalusi
2020-12-11 13:46 ` Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 17/20] dmaengine: ti: k3-udma: Initial support for K3 BCDMA Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 18/20] dmaengine: ti: k3-udma: Add support for BCDMA channel TPL handling Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 19/20] dmaengine: ti: k3-udma: Initial support for K3 PKTDMA Peter Ujfalusi
2020-12-08 9:04 ` [PATCH v3 20/20] dmaengine: ti: k3-udma-glue: Add " Peter Ujfalusi
2020-12-11 16:24 ` [PATCH v3 00/20] dmaengine/soc: k3-udma: Add support for BCDMA and PKTDMA Vinod Koul
2020-12-11 19:16 ` Peter Ujfalusi
2020-12-12 5:21 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208090440.31792-7-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox