Re: [PATCH] dmaengine: ti: edma: Fix reference count leaks due to pm_runtime_get_sync

Vinod Koul
2020-12-11T13:36:40Z

On 25-11-20, 08:36, Peter Ujfalusi wrote:
>
>
> On 24/11/2020 19.24, Vinod Koul wrote:
> > On 23-11-20, 21:59, Wang Xiaojun wrote:
> >> On calling pm_runtime_get_sync() the reference count of the device
> >> is incremented. In case of failure, should decrement the reference
> >> count before returning the error. So we fixed it by replacing it
> >> with pm_runtime_resume_and_get.
> >
> > Peter?
>
> Looks good.
>
> fwiw, the pm_runtime_resume_and_get() landed in mainline with v5.10-rc5,
> so it is fresh, but what it does is legit.

So I cant apply this patch, please rebase and resend after -rc1, with
Peter's ack

>
> Wang: thank you for the patch.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> >
> >>
> >> Signed-off-by: Wang Xiaojun <wangxiaojun11@huawei.com>
> >> ---
> >> drivers/dma/ti/edma.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> >> index 35d81bd857f1..38af8b596e1c 100644
> >> --- a/drivers/dma/ti/edma.c
> >> +++ b/drivers/dma/ti/edma.c
> >> @@ -2399,7 +2399,7 @@ static int edma_probe(struct platform_device *pdev)
> >> platform_set_drvdata(pdev, ecc);
> >>
> >> pm_runtime_enable(dev);
> >> - ret = pm_runtime_get_sync(dev);
> >> + ret = pm_runtime_resume_and_get(dev);
> >> if (ret < 0) {
> >> dev_err(dev, "pm_runtime_get_sync() failed\n");
> >> pm_runtime_disable(dev);
> >> --
> >> 2.25.1
> >
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

--
~Vinod