From: Vinod Koul <vkoul@kernel.org>
To: Parth Y Shah <sparth1292@gmail.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
dan.j.williams@intel.com, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: bam_dma: fix return of bam_dma_irq()
Date: Fri, 11 Dec 2020 19:48:41 +0530 [thread overview]
Message-ID: <20201211141841.GX8403@vkoul-mobl> (raw)
In-Reply-To: <1607322820-7450-1-git-send-email-sparth1292@gmail.com>
On 07-12-20, 12:03, Parth Y Shah wrote:
> While performing suspend/resume, we were getting below kernel crash.
>
> [ 54.541672] [FTS][Info]gesture suspend...
> [ 54.605256] [FTS][Error][GESTURE]Enter into gesture(suspend) failed!
> [ 54.605256]
> [ 58.345850] irq event 10: bogus return value fffffff3
> ......
>
> [ 58.345966] [<ffff0000080830f0>] el1_irq+0xb0/0x124
> [ 58.345971] [<ffff000008085360>] arch_cpu_idle+0x10/0x18
> [ 58.345975] [<ffff0000081077f4>] do_idle+0x1ac/0x1e0
> [ 58.345979] [<ffff0000081079c8>] cpu_startup_entry+0x20/0x28
> [ 58.345983] [<ffff000008a80ed0>] rest_init+0xd0/0xdc
> [ 58.345988] [<ffff0000091c0b48>] start_kernel+0x390/0x3a4
> [ 58.345990] handlers:
> [ 58.345994] [<ffff0000085120d0>] bam_dma_irq
>
> The reason for the crash we found is, bam_dma_irq() was returning
> negative value when the device resumes in some conditions.
>
> In addition, the irq handler should have one of the below return values.
>
> IRQ_NONE interrupt was not from this device or was not handled
> IRQ_HANDLED interrupt was handled by this device
> IRQ_WAKE_THREAD handler requests to wake the handler thread
>
> Therefore, to resolve this crash, we have changed the return value to
> IRQ_NONE.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2020-12-11 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 6:33 [PATCH] dmaengine: bam_dma: fix return of bam_dma_irq() Parth Y Shah
2020-12-11 14:18 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211141841.GX8403@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparth1292@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox