From: Vinod Koul <vkoul@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk()
Date: Mon, 21 Dec 2020 21:52:52 +0530 [thread overview]
Message-ID: <20201221162252.GH3323@vkoul-mobl> (raw)
In-Reply-To: <X9dTBFrUPEvvW7qc@mwanda>
On 14-12-20, 14:56, Dan Carpenter wrote:
> If the dw_edma_alloc_burst() function fails then we free "chunk" but
> it's still on the "desc->chunk->list" list so it will lead to a use
> after free. Also the "->chunks_alloc" count is incremented when it
> shouldn't be.
>
> In current kernels small allocations are guaranteed to succeed and
> dw_edma_alloc_burst() can't fail so this will not actually affect
> runtime.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2020-12-21 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:56 [PATCH] dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk() Dan Carpenter
2020-12-16 17:13 ` Gustavo Pimentel
2020-12-21 16:22 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221162252.GH3323@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox