Re: [PATCH -next] qcom: bam_dma: Delete useless kfree code

Bjorn Andersson
2020-12-16T18:33:37Z

On Wed 16 Dec 07:06 CST 2020, Zheng Yongjun wrote:

> The parameter of kfree function is NULL, so kfree code is useless, delete it.
> Therefore, goto expression is no longer needed, so simplify it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> drivers/dma/qcom/bam_dma.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> index 4eeb8bb27279..78df217b3f6c 100644
> --- a/drivers/dma/qcom/bam_dma.c
> +++ b/drivers/dma/qcom/bam_dma.c
> @@ -630,7 +630,7 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan,
> GFP_NOWAIT);
>
> if (!async_desc)
> - goto err_out;
> + return NULL;
>
> if (flags & DMA_PREP_FENCE)
> async_desc->flags |= DESC_FLAG_NWD;
> @@ -670,10 +670,6 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan,
> }
>
> return vchan_tx_prep(&bchan->vc, &async_desc->vd, flags);
> -
> -err_out:
> - kfree(async_desc);
> - return NULL;
> }
>
> /**
> --
> 2.22.0
>