From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20753C433DB for ; Tue, 12 Jan 2021 12:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D27A722BE9 for ; Tue, 12 Jan 2021 12:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728906AbhALMcM (ORCPT ); Tue, 12 Jan 2021 07:32:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:48122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbhALMcM (ORCPT ); Tue, 12 Jan 2021 07:32:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CCD3F23109; Tue, 12 Jan 2021 12:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610454692; bh=BtD61F+RAP3Yv3WfEUjwIDVe48zMPhJpisO2OtiId90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuPDxeFiitS2kKFvGgE7iRl8XKs6QeHdTqOebZfJb3wfW499VmSKT6o9Dj7IBeqar WlQEUHtRvVEneCm9zePEkO68iG1Af0Usb6+Rur53obIYiKSjQSzZCiyShkEVceJsOT kKTkqN1OQOP4HOpWdb8UUbKWrxU3czq7+ELhQKEHPfAupzrxNjZOrOPcCewGJIGRjP 6vv6THKmCTCribmRuxfig4kmtbCEetXeHP7LYGSwdTH3BiqbIQ/SD5O++GEfMasbfz iAvU5K738yBEu/LH6ehrjG4QyuMxaB1iCDoeY/jLlewp2Cr34NBbf4aDnWwePzoN/0 s08pGBtLQGBXw== Date: Tue, 12 Jan 2021 18:01:27 +0530 From: Vinod Koul To: Christophe JAILLET Cc: dan.j.williams@intel.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] dmaengine: owl-dma: Fix a resource leak in the remove function Message-ID: <20210112123127.GT2771@vkoul-mobl> References: <20201212162535.95727-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201212162535.95727-1-christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 12-12-20, 17:25, Christophe JAILLET wrote: > A 'dma_pool_destroy()' call is missing in the remove function. > Add it. > > This call is already made in the error handling path of the probe function. Applied, thanks -- ~Vinod