From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7091C433DB for ; Tue, 19 Jan 2021 18:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66E5E22E00 for ; Tue, 19 Jan 2021 18:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729843AbhASSsO (ORCPT ); Tue, 19 Jan 2021 13:48:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:49904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730097AbhASS22 (ORCPT ); Tue, 19 Jan 2021 13:28:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4BFE20706; Tue, 19 Jan 2021 16:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611074312; bh=bYfPJr7IQjJOjlgpiF/HJm9OHSZLjC+nl2dgDEXIMYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ABvBWkGe+Mz1LPmpywiu90WQvntlmqlR5etSKZQj0pY5L3xN+efqwcSiLHUlOj2+K Tq74Q3k228tTU3ILHUiGAVoGAnq4jOabygXSbSUCOeQgwVZGYDm75U7PfUQ7ZwRYzY jV15Keifg47loly+w2vRggSSOmXMNaNWiBauiU8ts6B4FD08Nw+qHjxYNGWCbqCwsS ku5Ww9fiZ3+3tgSKWnux19PI57fipZmeJtcyqATQgDnji3F35KA+xylGtQbZjbkwe3 i1KrTY43JgGQrU4Jgx2TtpEfLmVOQ/jgIlp19X98lvwsFk5wkg/b5ZRzTJCN8O7/+4 ufNWUtiNlogow== Date: Tue, 19 Jan 2021 22:08:22 +0530 From: Vinod Koul To: Dave Jiang Cc: dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: add module parameter to force disable of SVA Message-ID: <20210119163822.GC2771@vkoul-mobl> References: <161074811013.2184257.13335125853932003159.stgit@djiang5-desk3.ch.intel.com> <20210117065115.GL2771@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 18-01-21, 10:06, Dave Jiang wrote: > > On 1/16/2021 11:51 PM, Vinod Koul wrote: > > On 15-01-21, 15:01, Dave Jiang wrote: > > > Add a module parameter that overrides the SVA feature enabling. This keeps > > > the driver in legacy mode even when intel_iommu=sm_on is set. In this mode, > > > the descriptor fields must be programmed with dma_addr_t from the Linux DMA > > > API for source, destination, and completion descriptors. > > > > > > Signed-off-by: Dave Jiang > > > --- > > > drivers/dma/idxd/init.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c > > > index 25cc947c6179..9687a24ff982 100644 > > > --- a/drivers/dma/idxd/init.c > > > +++ b/drivers/dma/idxd/init.c > > > @@ -26,6 +26,10 @@ MODULE_VERSION(IDXD_DRIVER_VERSION); > > > MODULE_LICENSE("GPL v2"); > > > MODULE_AUTHOR("Intel Corporation"); > > > +static bool sva = true; > > > +module_param(sva, bool, 0644); > > > +MODULE_PARM_DESC(sva, "Toggle SVA support on/off"); > > Documentation for this please.. > > Just comments or is there somewhere specific for driver module parameter > documentations? All the parameters are supposed to be documented in Documentation/admin-guide/kernel-parameters.txt Thanks -- ~Vinod